build: suppress lint-md output #16551
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added the build 
Member Author
Previous output after installing remark:▶ make lint ~/wrk/com/DANGER/node (master) Running JS linter... ./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.mjs,.md \ benchmark doc lib test tools Running C++ linter... Total errors found: 0 if [ ! -d tools/remark-cli/node_modules ]; then \ cd tools/remark-cli && ../.././node ../.././deps/npm/bin/npm-cli.js install; fi if [ ! -d tools/remark-preset-lint-node/node_modules ]; then \ cd tools/remark-preset-lint-node && ../.././node ../.././deps/npm/bin/npm-cli.js install; fi Running Markdown linter... ./node tools/remark-cli/cli.js -q -f \ ./*.md doc src lib benchmark tools/doc/ tools/icu/New output after installing remark▶ make lint ~/wrk/com/node (quiet-lint*) Running JS linter... ./node tools/eslint/bin/eslint.js --cache --rulesdir=tools/eslint-rules --ext=.js,.mjs,.md \ benchmark doc lib test tools Running C++ linter... Total errors found: 0 Running Markdown linter... ./node tools/remark-cli/cli.js -q -f \ ./*.md doc src lib benchmark tools/doc/ tools/icu/Output when you install remarkMarkdown linter: installing remark-cli into tools/ > fsevents@1.1.2 install /Users/gib/wrk/com/node/tools/remark-cli/node_modules/fsevents > node install [... lots of npm output here ...] added 272 packages in 8.462s Markdown linter: installing remark-preset-lint-node into tools/ npm notice created a lockfile as package-lock.json. You should commit this file. npm WARN You are using a pre-release version of node and things may not work as expected added 48 packages in 2.016s Running Markdown linter... ./node tools/remark-cli/cli.js -q -f \ ./*.md doc src lib benchmark tools/doc/ tools/icu/ make: *** [lint] Error 2I think keeping the npm install output is important. |
cjihrig approved these changes Oct 27, 2017
| Dupe of #16508 no? |
apapirovski approved these changes Oct 27, 2017
Contributor
apapirovski left a comment
apapirovski left a comment There was a problem hiding this comment.
I slightly prefer this one, or if @danbev modifies theirs to match. I don't think it should be made completely silent.
Member Author
2 tasks
joyeecheung approved these changes Oct 28, 2017
jasnell approved these changes Oct 29, 2017
Member Author
XadillaX approved these changes Oct 30, 2017
2 tasks
Member Author
| Better fix at #16635, will close if that lands. |
watilde approved these changes Nov 1, 2017
We don't need to print out the output if we've already installed it, at the same time we do want to see some output when we haven't installed. PR-URL: nodejs#16551 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
cjihrig pushed a commit to cjihrig/node that referenced this pull request Nov 6, 2017
We don't need to print out the output if we've already installed it, at the same time we do want to see some output when we haven't installed. PR-URL: nodejs#16551 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
gibfahn added a commit that referenced this pull request Nov 14, 2017
We don't need to print out the output if we've already installed it, at the same time we do want to see some output when we haven't installed. PR-URL: #16551 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Khaidi Chu <i@2333.moe> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We don't need to print out the output if we've already installed it, at
the same time we do want to see some output when we haven't installed.
Checklist
Affected core subsystem(s)
build