test: use process.features.debug in common module #16537
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Replace process.config.target_defaults.default_configuration check with process.features.debug. Refs: nodejs#4431 (comment)
Member Author
| ping @skomski |
refack approved these changes Oct 27, 2017
gireeshpunathil approved these changes Oct 27, 2017
jasnell reviewed Oct 27, 2017
| | ||
| exports.platformTimeout = function(ms) { | ||
| if (process.config.target_defaults.default_configuration === 'Debug') | ||
| if (process.features.debug) |
Member
There was a problem hiding this comment.
just keep in mind that process.features is mutable by end users...
jasnell approved these changes Oct 27, 2017
lpinca approved these changes Oct 27, 2017
cjihrig approved these changes Oct 27, 2017
Member
Member Author
| Lone CI failure is build related. |
Member Author
| Landed in 98eab4a |
Trott added a commit to Trott/io.js that referenced this pull request Oct 27, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs#16537 Ref: nodejs#4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Contributor
| When was |
Member
| git blame says six years ago: aa0308d |
Member
| (there's a certain irony in |
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 30, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit that referenced this pull request Oct 31, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs/node#16537 Ref: nodejs/node#4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Qard pushed a commit to ayojs/ayo that referenced this pull request Nov 2, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs/node#16537 Ref: nodejs/node#4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: #16537 Ref: #4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
Replace process.config.target_defaults.default_configuration check with process.features.debug. PR-URL: nodejs/node#16537 Ref: nodejs/node#4431 (comment) Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replace process.config.target_defaults.default_configuration check with
process.features.debug.
Refs: #4431 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test