doc: add recommendations for first timers #16350
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
COLLABORATOR_GUIDE.md Outdated
Contributor
There was a problem hiding this comment.
recommanded -> recommended ?
Member
There was a problem hiding this comment.
You could also drop the first four words:
Be extra welcoming to "first-time-contributors".
I'd use especially in place of extra and lose the unnecessary quotes and hyphens:
Be especially welcoming to first time contributors.
COLLABORATOR_GUIDE.md Outdated
Contributor
There was a problem hiding this comment.
- recommanded -> recommended ?
- Avoid "you"?
Member
There was a problem hiding this comment.
Maybe remove the "it is recommended that you"?:
For first time contributors, ask the author if they have configured...
Trott reviewed Oct 22, 2017
COLLABORATOR_GUIDE.md Outdated
Member
There was a problem hiding this comment.
Not an objection, but just a comment that I try to be very sparing with bold, italics, etc. It gets out of hand pretty easily.
Trott reviewed Oct 22, 2017
COLLABORATOR_GUIDE.md Outdated
joyeecheung approved these changes Oct 22, 2017
jasnell reviewed Oct 22, 2017
COLLABORATOR_GUIDE.md Outdated
Member
There was a problem hiding this comment.
minor nit: blank line before this sentence?
gireeshpunathil approved these changes Oct 23, 2017
refack force-pushed the collab-guide-tweaks branch from bb62506 to f5c8192 Compare 
refack commented Oct 23, 2017
COLLABORATOR_GUIDE.md Outdated
Contributor Author
There was a problem hiding this comment.
Not an objection, but just a comment that I try to be very sparing with bold, italics, etc. It gets out of hand pretty easily.
Ack. I felt this is a point worth emphasising both to Collaborators, and to contributors who read this (as on most screens it appears above the fold)
Contributor Author
| Addressed comment PTAL |
gibfahn approved these changes Oct 23, 2017
apapirovski approved these changes Oct 23, 2017
refack force-pushed the collab-guide-tweaks branch from f5c8192 to a9de89a Compare PR-URL: nodejs#16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
cjihrig pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
PR-URL: nodejs/node#16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
PR-URL: #16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#16350 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc,meta