-
- Notifications
You must be signed in to change notification settings - Fork 33.7k
Replaced assert.strictEqual() error messages with template literals #15910
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
watilde approved these changes Oct 6, 2017
ab62dc2 to a4a034f Compare watilde approved these changes Oct 6, 2017
Contributor
Contributor
| @sashimii, welcome and thank you for the PR. |
refack approved these changes Oct 6, 2017
BridgeAR approved these changes Oct 9, 2017
Member
| @refack that test is flaky and we do not yet know why. There is a open issue for it. |
BridgeAR pushed a commit that referenced this pull request Oct 9, 2017
PR-URL: #15910 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
| Landed in 3953164 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins pushed a commit that referenced this pull request Oct 11, 2017
PR-URL: #15910 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
addaleax pushed a commit to addaleax/ayo that referenced this pull request Oct 12, 2017
PR-URL: nodejs/node#15910 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 17, 2017
PR-URL: #15910 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins pushed a commit that referenced this pull request Oct 18, 2017
PR-URL: #15910 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Oct 25, 2017
PR-URL: #15910 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cluster Issues and PRs related to the cluster subsystem. code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests.
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Pull request from Code & Learn!
In
test/parallel/test-cluster-send-handle-twice.js, there are calls to thestrictEqualmethod in theassertmodule. Literals were being passed into the message argument and the values of the error messages were not being printed. Two strictEqual messages have been changed to template literals that now include thecodeandsignalvalues in the error messages.Checklist
Affected core subsystem(s)