test: change to common fixtures module in test file #15886
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay!
Trott added the code-and-learn 
BridgeAR reviewed Oct 9, 2017
| key: fs.readFileSync(`${common.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${common.fixturesDir}/keys/agent1-cert.pem`) | ||
| key: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-key.pem`), | ||
| cert: fs.readFileSync(`${fixtures.fixturesDir}/keys/agent1-cert.pem`) |
Member
There was a problem hiding this comment.
There is a dedicated fixtures.readKey function that should be used here. In that case the line is much shorter and you only have to provide the file name.
Author
There was a problem hiding this comment.
@BridgeAR, so for example?
key: fixtures.readKey(`agent1-key.pem`), 
lpinca reviewed Oct 10, 2017
Member
There was a problem hiding this comment.
Nit: can you please move this after the common.hasCrypto check?
Member
There was a problem hiding this comment.
This line can simply be key: fixtures.readKey('agent1-key.pem').
bobclewell force-pushed the feature/replace-fixturesDir-with-fixtures-module-in-http-set-timeout-server branch from f574cd4 to 12da58b Compare lpinca reviewed Oct 10, 2017
Member
There was a problem hiding this comment.
One last nit: this is no longer needed, so if you can please remove it. Thanks.
Member
There was a problem hiding this comment.
Something went wrong with last change as you removed fixtures instead of fs :)
Author
There was a problem hiding this comment.
Oops. Fixed now. 😄
(fingers-crossed)
bobclewell force-pushed the feature/replace-fixturesDir-with-fixtures-module-in-http-set-timeout-server branch from 12da58b to f5572dd Compare bobclewell force-pushed the feature/replace-fixturesDir-with-fixtures-module-in-http-set-timeout-server branch from f5572dd to e1089e2 Compare lpinca approved these changes Oct 10, 2017
gireeshpunathil approved these changes Oct 12, 2017
Member
jasnell approved these changes Oct 13, 2017
jasnell pushed a commit that referenced this pull request Oct 13, 2017
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: #15886 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
| Landed in 0e1455b |
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: nodejs/node#15886 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: #15886 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: #15886 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: #15886 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
Task to replace the common.fixturesDir with the usage of the common.fixtures module. At Node.js Interactive. First PR to Node.js. Yay! PR-URL: #15886 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Task to replace the common.fixturesDir with the usage
of the common.fixtures module. At Node.js Interactive.
First PR to Node.js. Yay!
Checklist
make -j4 test(UNIX)Affected core subsystem(s)
test