test: fix fixturesDir in test-https-truncate.js #15875
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Trott added the code-and-learn 
Member
| Hi, @genewoo! Welcome and thanks for this! Can you please update this to use |
jasnell reviewed Oct 10, 2017
test/parallel/test-https-truncate.js Outdated
Member
There was a problem hiding this comment.
These can be:
const key = fixtures.readKey('agent1-key.pem'); const cert = fixtures.readKey('agent1-cert.pem');
lpinca reviewed Oct 10, 2017
test/parallel/test-https-truncate.js Outdated
Member
There was a problem hiding this comment.
Nit: can you please move this after the common.hasCrypto check?
Member
| ping @genewoo |
cjihrig approved these changes Oct 15, 2017
Contributor
cjihrig left a comment
cjihrig left a comment There was a problem hiding this comment.
LGTM once updated to address nits.
hiroppy approved these changes Oct 15, 2017
common.fixturesDir -> fixtures.readKey
Trott force-pushed the code_learn_node_interactive_2017_q_2 branch from d78925b to cca0138 Compare Member
| I fixed the nits and pushed it up to the branch. Not starting CI because there seem to be issues with ubuntu1604-intel-64 that are causing CI to back up and I don't want to make things worse. (ping @nodejs/build) |
jasnell approved these changes Oct 18, 2017
BridgeAR approved these changes Oct 18, 2017
BridgeAR pushed a commit that referenced this pull request Oct 19, 2017
PR-URL: #15875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Member
| Landed in c35a3e0 Thanks for the PR, and congratulations on becoming a Node.js Contributor 🎉 ! |
MylesBorins pushed a commit that referenced this pull request Oct 23, 2017
PR-URL: #15875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 26, 2017
PR-URL: nodejs/node#15875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #15875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #15875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
PR-URL: #15875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
addaleax pushed a commit to ayojs/ayo that referenced this pull request Dec 7, 2017
PR-URL: nodejs/node#15875 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
N/A