test: replace common.fixturesDir with usage of the common.fixtures #15870
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| There is a dedicated method for reading keys in fixtures module I would suggest using it. |
alodela force-pushed the common-fixtures-https-close branch from fbd8664 to f06f6b7 Compare 
Contributor Author
| @pawelgolda Thanks for pointing that out! I have changed the code to use |
Trott added the code-and-learn 
cjihrig approved these changes Oct 7, 2017
benjamingr approved these changes Oct 7, 2017
jasnell approved these changes Oct 10, 2017
lpinca reviewed Oct 10, 2017
| @@ -1,14 +1,15 @@ | |||
| 'use strict'; | |||
| const common = require('../common'); | |||
| const fixtures = require('../common/fixtures'); | |||
Member
There was a problem hiding this comment.
Nit: would you mind moving this after the common.hasCrypto check?
lpinca approved these changes Oct 10, 2017
Member
jasnell approved these changes Oct 13, 2017
jasnell pushed a commit that referenced this pull request Oct 13, 2017
PR-URL: #15870 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Member
| Landed in a9a0146 |
addaleax pushed a commit to ayojs/ayo that referenced this pull request Oct 15, 2017
PR-URL: nodejs/node#15870 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Oct 18, 2017
PR-URL: #15870 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 16, 2017
PR-URL: #15870 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Nov 21, 2017
PR-URL: #15870 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Nov 28, 2017
PR-URL: #15870 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
11 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Replaces usage of common.fixturesDir with common.fixtures module in test/parallel/test-https-close.js
Node.js Interactive 2017 Code & Learn workshop
Checklist
make -j4 test(UNIX) passesAffected core subsystem(s)
test