Skip to content

Conversation

@Trott
Copy link
Member

@Trott Trott commented Sep 25, 2017

The countdown and fixtures modules are documented in the
common/README.md file but are omitted from the table of contents. Add
them.

Checklist
Affected core subsystem(s)

doc test

The `countdown` and `fixtures` modules are documented in the `common/README.md` file but are omitted from the table of contents. Add them.
@Trott Trott added doc Issues and PRs related to the documentations. test Issues and PRs related to the tests. labels Sep 25, 2017
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops! Thank you!

@Trott
Copy link
Member Author

Trott commented Sep 27, 2017

Landed in 1f21a5c

@Trott Trott closed this Sep 27, 2017
Trott added a commit that referenced this pull request Sep 27, 2017
The `countdown` and `fixtures` modules are documented in the `common/README.md` file but are omitted from the table of contents. Add them. PR-URL: #15595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2017
The `countdown` and `fixtures` modules are documented in the `common/README.md` file but are omitted from the table of contents. Add them. PR-URL: #15595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 29, 2017
The `countdown` and `fixtures` modules are documented in the `common/README.md` file but are omitted from the table of contents. Add them. PR-URL: #15595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
addaleax pushed a commit to addaleax/ayo that referenced this pull request Sep 30, 2017
The `countdown` and `fixtures` modules are documented in the `common/README.md` file but are omitted from the table of contents. Add them. PR-URL: nodejs/node#15595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 3, 2017
MylesBorins pushed a commit that referenced this pull request Oct 3, 2017
The `countdown` and `fixtures` modules are documented in the `common/README.md` file but are omitted from the table of contents. Add them. PR-URL: #15595 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins
Copy link
Contributor

This does not land cleanly in LTS. Please feel free to manually backport by following the guide. Please also feel free to replace do-not-land if it is being backported

@Trott Trott deleted the update-common-readme branch January 13, 2022 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Issues and PRs related to the documentations. test Issues and PRs related to the tests.

6 participants