Backport 12162 to 6.x #12504
Closed
Backport 12162 to 6.x #12504
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added tools 2 tasks
Contributor
Member Author
| Well that's too bad. I thought I ran the linter to make sure it was working. Guess I did not. |
Trott force-pushed the backport-12162-to-6.x branch from 35ccdd7 to fcc759f Compare Member Author
| OK, fixed. At least the lint rules are fixed anyway. Sorry about that. |
Contributor
| Cool. Trying CI one more time.. https://ci.nodejs.org/job/node-test-pull-request/7541/ |
Member Author
| Is the FreeBSD test-net-write-after-close failure a known flaky on the v6.x branch? Seems unrelated to this... |
Contributor
| @Trott it isn't flaky AFAIK... will run tests again on release branch to check |
MylesBorins force-pushed the v6.x-staging branch from 404d1bc to 99dab5b Compare Member Author
Member Author
| Only CI failure is build/infra related. |
PR-URL: nodejs#12162 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
ESLint 3.19.0 allows the specification of selectors that represent disallowed syntax. Replace our custom rule for timer arguments with a pair of `no-restricted-syntax` option objects.
Trott force-pushed the backport-12162-to-6.x branch from fcc759f to d533e92 Compare Member Author
| CI again post-rebase: https://ci.nodejs.org/job/node-test-pull-request/7679/ |
Member Author
| CI looks good. Just the usual clang bot failure on v6.x. (At least, I think it's the usual. Regardless, it's build-related, not related to this change.) |
MylesBorins pushed a commit that referenced this pull request Apr 26, 2017
ESLint 3.19.0 allows the specification of selectors that represent disallowed syntax. Replace our custom rule for timer arguments with a pair of `no-restricted-syntax` option objects. PR-URL: #12504 Reviewed-By: Myles Borins <myles.borins@gmail.com>
Contributor
| landed in 9218661...cf26d15 |
MylesBorins pushed a commit that referenced this pull request May 2, 2017
ESLint 3.19.0 allows the specification of selectors that represent disallowed syntax. Replace our custom rule for timer arguments with a pair of `no-restricted-syntax` option objects. PR-URL: #12504 Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Backport-PR-URL: nodejs/node#12504 PR-URL: nodejs/node#12162 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
ESLint 3.19.0 allows the specification of selectors that represent disallowed syntax. Replace our custom rule for timer arguments with a pair of `no-restricted-syntax` option objects. PR-URL: nodejs/node#12504 Reviewed-By: Myles Borins <myles.borins@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
backport of #12162 to 6.x
@MylesBorins