v7.9.0 Release Proposal #12319
Merged
v7.9.0 Release Proposal #12319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
PR-URL: #12268 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
This change brings formatting specifiers available in `util.format` and consequently, `console.*` closer to what is supported in all major browsers. - `%i` is introduced to format integer values. - `%f` is introduced to format floating point values. Fixes: #10292 PR-URL: #10308 Reviewed-By: James M Snell <jasnell@gmail.com>
Commit 9c9e2d7 changed the name of TypeFeedbackVector to FeedbackVector but that commit did not update gdbinit. This applies the changed to gdbinit from upstream V8. Original commit message: [gdbinit] Rename TypeFeedback* to Feedback*. BUG= Change-Id: I1e32fdcf9edda57f5de329c8b694620a5da4558b Reviewed-on: https://chromium-review.googlesource.com/442444 Reviewed-by: Michael Stanton <mvstanton@chromium.org> Commit-Queue: Igor Sheludko <ishell@chromium.org> Cr-Commit-Position: refs/heads/master@{#43185} PR-URL: #12060 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
* we use u_setDataDirectory() in "unicode/putil.h" * at present, this header is indirectly included, but this will change in ICU 59 * no impact on past ICUs. * this is an exact analog to #11753 PR-URL: #12078 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
This is a fix for test-child-process-exec-kill-throws which is currently flaky on Windows. A bug in the test was causing the child process to fail for reasons other than those intended by the test. Instead of failing for exceeding the `maxBuffer` setting, the test was failing because it was trying to load `internal/child_process` without being passed the `expose-internals` flag. Move that module to where only the parent process (which gets the flag) loads it. Additionally, improve an assertion message to help debug problems like this. PR-URL: #12111 Fixes: #12053 Reviewed-By: Richard Lau <riclau@uk.ibm.com>
.eslintrc was renamed in #7699 to .eslintrc.yaml. PR-URL: #12116 Refs: #7699 Reviewed-By: Claudio Rodriguez <cjrodr@yahoo.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Currently, when in strict mode, function declarations are copied on the sandbox by CopyProperties(), which is not necessary and will break when CP is removed. This change maintains current behavior, letting GlobalPropertySetterCallback copy functions on the sandbox instead of using CP to do the task. PR-URL: #12051 Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net>
* Rename listen to listenInCluster * Rename _listen2 to _setupListenHandle * Remove _listen since it's a one-liner only used in one place * Correct comments in server.listen PR-URL: #11796 Reviewed-By: James M Snell <jasnell@gmail.com>
Adds a centered logo to the README to make it a little more festive. As centering is not possible in pure Markdown, a bit of HTML is used. PR-URL: #12148 Ref: #6920 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Updates: + Bring tests url-setter-tests from WPT, and put it as JavaScript + Comment out unpassed tests Refs: web-platform-tests/wpt#5112 Refs: #11887 PR-URL: #12058 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com>
This test is allocating much more memory than necessary to actually reproduce the original problem. Lowering the amount of memory allocated increases performance at least in some cases and makes this test less likely to time out on SmartOS. PR-URL: #11177 Ref: #10166 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Julien Gilli <jgilli@nodejs.org> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Document that `node --inspect=${port}` is also a viable option. PR-URL: #12149 Reviewed-By: Eugene Ostroukhov <eostroukhov@google.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Also allows someone to reassign `$RM`, e.g. with `RM=rm -v` instead of `rm -f` (the default) should they want to. We're currently using a mixture of `$(RM)` and `rm -f`. There are a couple of places which aren't doing -f, have them do it for consistency. PR-URL: #12157 Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
At least starting with Darwin Kernel Version 16.4.0, sending a SIGTERM to a process that is still starting up kills it with SIGKILL instead of SIGTERM. PR-URL: #12159 Refs: libuv/libuv#1226 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Also add a benchmark to compare both ways to create strings. PR-URL: #12170 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
* replace `var` by `const` in http.md * replace `let` by `const` in http.md * fix spaces in code examples of http.md * replace console.log() by .error() in http.md * make arrow function clearer in http.md * use object destructuring in http.md * update output examples in http.md PR-URL: #12169 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
PR-URL: #12163 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The fast base64 decoder used to switch to the slow one permanently when it saw a whitespace or other garbage character. Since the most common situation such characters may be encountered in is line-wrapped base64 data, a more profitable strategy is to decode a single 24-bit group with the slow decoder and then continue running the fast algorithm. PR-URL: #12146 Ref: #12114 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Trevor Norris <trev.norris@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
not needed according to official python docs - https://docs.python.org/2/library/subprocess.html#index-2 PR-URL: #12138 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This commit updates 3 additional references to Mac OS X in releases.md to macOS. PR-URL: #12106 Fixes: #12086 Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #12162 Reviewed-By: Teddy Katz <teddy.katz@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Use the remaining listener directly if the array of listeners has only one element after running `EventEmitter.prototype.removeListener()`. Advantages: - Better memory usage and better performance if no new listeners are added for the same event. Disadvantages: - A new array must be created if new listeners are added for the same event. PR-URL: #12043 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: Ron Korving <ron@ronkorving.nl>
About fs.read's 2nd argument, string is invalid. PR-URL: #12034 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
About setImmediate, the execution timing is after timers currently. PR-URL: #12034 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Something unidentified at the moment is causing the arrays benchmarks to deopt when run with the TurboFan compiler. Refactor the test to use an inner function that can be correctly optimized by TurboFan and Crankshaft. PR-URL: #11894 Ref: #11851 (comment) Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
look for the actual produced `exe` not just the directory PR-URL: #12120 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Nikolai Vavilov <vvnicholas@gmail.com>
PR-URL: #11635 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
This test ensures that UTF-8 characters can be used in core JavaScript modules built into Node's binary. PR-URL: #11423 Ref: #11129 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
nodejs-github-bot added doc 
italoacasas removed build PR-URL: #12109 Reviewed-By: James M Snell <jasnell@gmail.com>
Where inclusion of a lengthy URL causes a line to exceed 80 characters in our code base, do not report the line length as a linting error. PR-URL: #11890 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #12102 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Original commit message: Only flush not yet started and finished compile jobs from gc We shouldn't block during GC for arbitrarily long intervals. BUG=chromium:686153,chromium:642532 R=verwaest@chromium.org,hpayer@chromium.org Review-Url: https://codereview.chromium.org/2658313002 Cr-Commit-Position: refs/heads/master@{#42761} PR-URL: #11998 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor
| PRs against current |
Author
| @aqrln where are you seeing that? |
Contributor
| @aqrln According to @MylesBorins it may be a known "issue." |
Contributor
Author
| cc @nodejs/build @MylesBorins ^^^ |
Contributor
| @mscdex ah, I see, didn't know it had already been reported. Thanks. |
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 11, 2017
PR-URL: nodejs#12319
italoacasas pushed a commit to italoacasas/node that referenced this pull request Apr 11, 2017
Notable changes: * util: console is now closer to what is supported in all major browsers (Roman Reiss) [nodejs#10308](nodejs#10308) PR-URL: nodejs#12319
italoacasas pushed a commit to italoacasas/nodejs.org that referenced this pull request Apr 11, 2017
italoacasas pushed a commit to nodejs/nodejs.org that referenced this pull request Apr 11, 2017
imyller pushed a commit to imyller/meta-nodejs that referenced this pull request Apr 20, 2017
Notable changes: * util: console is now closer to what is supported in all major browsers (Roman Reiss) [#10308](nodejs/node#10308) PR-URL: nodejs/node#12319 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
2017-04-11, Version 7.9.0 (Current), @italoacasas
Notable Changes
Tests
Commits
Semver Minor
1ee38eb874] - (SEMVER-MINOR) util: add %i and %f formatting specifiers (Roman Reiss) [util: add %i and %f formatting specifiers #10308]Semver Patch
9f73df5910] - deps: cherry-pick 22858cb from V8 upstream (Ali Ijaz Sheikh) #11998b997e62692] - test: add internal/socket_list tests (DavidCai) #12109c11c23b22b] - doc: make the heading consistent (Sakthipriyan Vairamani (thefourtheye)) #1156967d21149a2] - crypto: handle exceptions in hmac/hash.digest (Tobias Nießen) #121643b765f5366] - doc: fix confusing example in process.md (Vse Mozhet Byt) #1228237568c093a] - src: use std::list for at_exit_functions (Daniel Bevenius) #122552f9e2fcf3e] - doc: update information on test/known_issues (Jan Krems) #122620f4319a14a] - src: use std::string for trace enabled_categories (Sam Roberts) #122426826637f11] - doc: fix missing argument for dns.resolvePtr() (Uppinder Chugh) #122564a6bb378d4] - doc: fix confusing reference in net.md (Vse Mozhet Byt) #122473e8991cc56] - doc: modernize and fix code examples in modules.md (Vse Mozhet Byt) #12224376f5ef1ee] - doc: document the performance team (Gibson Fahnestock) #12213c0b7c075da] - doc: add refack to collaborators (Refael Ackermann) #1227783f855d505] - doc: add aqrln to collaborators (Alexey Orlenko) #122732fb2289177] - doc: add sub domain to host in url (Steven) #12233ac200a6122] - test: add a second argument to assert.throws() (dave-k) #121393cdd04b1c0] - test: skip irrelevant test on Windows (Rich Trott) #12261d4d6986551] - build: fix path voodoo in icu-generic.gyp (Refael Ackermann) #11217a735c16d52] - deps: backport ec1ffe3 from upstream V8 (Daniel Bevenius) #12061d641164d09] - doc: update pull request template URL layout (Rich Trott) #122166feea08587] - buffer: preallocate array with buffer length (alejandro) #11733a703bdecc4] - build: add checks for openssl configure options (Daniel Bevenius) #12175b495b6acdf] - build: make configure print statements consistent (Daniel Bevenius) #12176f60b4553f3] - doc: modernize and fix code examples in https.md (Vse Mozhet Byt) #1217174d0266694] - doc: fix string interpolation in Stream 'finish' (Vinay Hiremath) #122214b54520a4a] - test: refactor mkdtemp test and added async (Luca Maraschi) #120808caf6fd58a] - test: add Unicode characters regression test (Alexey Orlenko) #11423961c89cc61] - doc: add table of contents to README.md (Jason Marsh) #11635a11ed6a0b3] - test: more robust check for location ofnode.exe(Refael Ackermann) #121206083e7aa7b] - benchmark: avoid TurboFan deopt in arrays bench (Michaël Zasso) #11894cf1117bc13] - doc: fix the timing of setImmediate's execution (Daiki Arai) #12034806c4f3c0c] - doc: fix fs.read arg type (Daiki Arai) #12034c814c7e9ea] - events: do not keep arrays with a single listener (Luigi Pinca) #1204336617fd5b8] - doc: add notes to http.get options (Raphael Okon) #121249e6b0a4604] - test: performance, remove Popen(shell=True) on Win (Refael Ackermann) #12138805ebef8b1] - buffer: optimize decoding wrapped base64 data (Alexey Orlenko) #12146fb34d9c210] - test: increase querystring coverage (DavidCai) #12163d6e9cf7c22] - doc: fix and update examples in http.md (Vse Mozhet Byt) #12169f057cc3d84] - benchmark: replace [].join() with ''.repeat() (Vse Mozhet Byt) #12170b15dc95848] - test: fix flaky test-child-process-exec-timeout (Santiago Gimeno) #1215972a27b3eb5] - build: use $(RM) in Makefile for consistency (Gibson Fahnestock) #121573af9101d20] - doc, inspector: note that the host is optional (Gibson Fahnestock) #12149b52b3f6710] - test: reduce buffer size in buffer-creation test (Sakthipriyan Vairamani (thefourtheye)) #11177b5283f9d4b] - doc: add logo to README (Roman Reiss) #12148305f822a36] - net: rename internal functions for readability (Joyee Cheung) #117962f88de1ce3] - vm: use SetterCallback to set func declarations (AnnaMag) #12051ffbcfdfe32] - src: fix base64 decoding (Nikolai Vavilov) #119958823861d9d] - tools: update dotfile whitelist in .gitignore (Michaël Zasso) #1211687ca9a6ffe] - test: fix flaky child-process-exec-kill-throws (Rich Trott) #12111fdf76d5aa0] - tools: add missing #include "unicode/putil.h" (Steven R. Loomis) #120786130d547a0] - deps: backport 8dde6ac from upstream V8 (Daniel Bevenius) #12060(util: add %i and %f formatting specifiers #10308)
5ac719d0d2] - doc: add deprecations page to docs toc (Michaël Zasso) #12268