src: remove outdated FIXME in node_crypto.cc #11669
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: nodejs#4641
nodejs-github-bot added c++ 
gibfahn approved these changes Mar 3, 2017
Member
gibfahn left a comment
gibfahn left a comment There was a problem hiding this comment.
LGTM based on #4641 (comment)
bnoordhuis approved these changes Mar 3, 2017
cjihrig approved these changes Mar 3, 2017
jasnell approved these changes Mar 3, 2017
danbev added a commit to danbev/node that referenced this pull request Mar 4, 2017
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: nodejs#4641 PR-URL: nodejs#11669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Contributor Author
| Landed in 9352528 |
addaleax pushed a commit that referenced this pull request Mar 5, 2017
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: #4641 PR-URL: #11669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: #4641 PR-URL: #11669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: #4641 PR-URL: #11669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
Issue 4641 contains a FIXME regarding the InitCrypto function. After discussing this with bnoordhuis it seems to be an outdated comment. Refs: nodejs/node#4641 PR-URL: nodejs/node#11669 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Issue 4641 contains a FIXME regarding the InitCrypto function. After
discussing this with bnoordhuis it seems to be an outdated comment.
Refs: #4641
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
src