doc: fix WHATWG URL url.protocol example #11647
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Protocol of `https://example.org` is `https:` not `http:`.
nodejs-github-bot added doc 
jasnell approved these changes Mar 2, 2017
mscdex added whatwg-url 
TimothyGu approved these changes Mar 2, 2017
targos approved these changes Mar 2, 2017
cjihrig approved these changes Mar 2, 2017
Member
| This shouldn't need the fulll 48 hours to land |
jasnell pushed a commit that referenced this pull request Mar 2, 2017
Protocol of `https://example.org` is `https:` not `http:`. PR-URL: #11647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Member
| Landed in bb5c84a |
addaleax pushed a commit that referenced this pull request Mar 5, 2017
Protocol of `https://example.org` is `https:` not `http:`. PR-URL: #11647 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Timothy Gu <timothygu99@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The example given in the
url.protocolsection of the WHATWG URL doc should printhttps:instead ofhttp:forhttps://example.org.Checklist
Affected core subsystem(s)
doc