doc: make os api doc more consistent #10994
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This adds a missing Returns to os.arch() as well as a missing added in version to os.constants.
nodejs-github-bot added doc 
gibfahn approved these changes Jan 25, 2017
cjihrig approved these changes Jan 25, 2017
lpinca approved these changes Jan 25, 2017
Member
| I guess this shouldn't wait the 48h if it gets enough LGTM. |
Member
| @lpinca I agree it doesn't need to, but there's also no particular rush right? |
Member
| ofc not. |
jasnell approved these changes Jan 27, 2017
jasnell pushed a commit that referenced this pull request Jan 27, 2017
This adds a missing Returns to os.arch() as well as a missing added in version to os.constants. PR-URL: #10994 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Member
| Landed in 4f1e235 |
Contributor Author
| Thanks @jasnell, you beat me to it :] |
evanlucas added a commit that referenced this pull request Jan 31, 2017
This adds a missing Returns to os.arch() as well as a missing added in version to os.constants. PR-URL: #10994 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Apr 17, 2017
This adds a missing Returns to os.arch() as well as a missing added in version to os.constants. PR-URL: #10994 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Apr 19, 2017
This adds a missing Returns to os.arch() as well as a missing added in version to os.constants. PR-URL: #10994 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
This adds a missing Returns to os.arch() as well as a missing added in version to os.constants. PR-URL: nodejs/node#10994 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This adds a missing Returns to
os.arch()as well as a missing added inversion to
os.constants.Checklist
Affected core subsystem(s)
doc