test: add http-common's test #10832
Closed
test: add http-common's test #10832
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
nodejs-github-bot added test 
jasnell approved these changes Jan 16, 2017
Member
jasnell left a comment
jasnell left a comment There was a problem hiding this comment.
this is a good start. we should likely expand the range of tested inputs, however
cjihrig requested changes Jan 16, 2017
test/parallel/test-http-common.js Outdated
Contributor
There was a problem hiding this comment.
Can you make the comments match the case of the function calls.
test/parallel/test-http-common.js Outdated
Contributor
There was a problem hiding this comment.
Can you switch to assert.strictEqual(). It will make the code more readable, especially in the negated cases.
hiroppy force-pushed the feature/add-test-http-common branch from c747717 to edcf201 Compare 
Member Author
| @cjihrig Updated. |
cjihrig approved these changes Jan 16, 2017
lpinca reviewed Jan 17, 2017
test/parallel/test-http-common.js Outdated
Member
There was a problem hiding this comment.
Nit: how about adding the empty string case? It should slightly increase the coverage.
Member Author
There was a problem hiding this comment.
Agree. Added the empty string case.
lpinca approved these changes Jan 17, 2017
hiroppy force-pushed the feature/add-test-http-common branch from edcf201 to 9c3b340 Compare 
checkIsHttpToken: https://github.com/nodejs/node/blob/master/lib/_http_common.js#L267 checkInvalidHeaderChar: https://github.com/nodejs/node/blob/master/lib/_http_common.js#L318 Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/_http_common.js.html
hiroppy force-pushed the feature/add-test-http-common branch from 9c3b340 to 67d6261 Compare 
| Landed 165bf28 |
italoacasas pushed a commit that referenced this pull request Jan 18, 2017
PR-URL: #10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
PR-URL: nodejs#10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 23, 2017
PR-URL: nodejs#10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 25, 2017
PR-URL: nodejs#10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 27, 2017
PR-URL: nodejs#10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
PR-URL: #10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 8, 2017
PR-URL: #10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
PR-URL: #10832 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Add a test of
checkIsHttpTokenandcheckInvalidHeaderChar.checkIsHttpToken: https://github.com/nodejs/node/blob/master/lib/_http_common.js#L267
checkInvalidHeaderChar: https://github.com/nodejs/node/blob/master/lib/_http_common.js#L318
Coverage: https://coverage.nodejs.org/coverage-57f6a106fbc69a47/root/_http_common.js.html
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test