-
- Notifications
You must be signed in to change notification settings - Fork 33.7k
Closed
Labels
fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.moduleIssues and PRs related to the module subsystem.Issues and PRs related to the module subsystem.
Description
With the addition of PR #15767 the internal InternalModuleReadFile and pseudo exposed process.binding("fs").internalModuleReadFile are no longer generic read file helpers and are essentially locked down to just json. InternalModuleReadFile was more generically useful before and could have been applied to loading more than just json.
I think the name InternalModuleReadFile, and the pseudo exposed process.binding("fs").internalModuleReadFile, should either be renamed or a new internal for json-only should be created (maybe that wraps InternalModuleReadFile).
Metadata
Metadata
Assignees
Labels
fsIssues and PRs related to the fs subsystem / file system.Issues and PRs related to the fs subsystem / file system.moduleIssues and PRs related to the module subsystem.Issues and PRs related to the module subsystem.