Skip to content

events: performance regression in event benchmarks #12657

@jasnell

Description

@jasnell

See: #12655 (comment)

$ ./node benchmark/compare.js --old node --new ../main/node events > ~/eventsbench [00:10:21|% 100| 7/7 files | 60/60 runs | 1/1 configs]: Done james@ubuntu:~/node/node$cat ~/eventsbench | Rscript benchmark/compare.Rh improvement confidence p.value events/ee-add-remove.js n=250000 -45.73 % *** 8.380381e-18 events/ee-emit-multi-args.js n=2000000 0.70 % 2.285963e-01 events/ee-emit.js n=2000000 2.12 % *** 3.829377e-05 events/ee-listener-count-on-prototype.js n=50000000 -95.07 % *** 1.717885e-35 events/ee-listeners-many.js n=5000000 -20.60 % *** 8.616063e-14 events/ee-listeners.js n=5000000 -48.69 % *** 2.759171e-60 events/ee-once.js n=20000000 -58.16 % *** 3.019260e-56 

I'm seeing a significant performance regression in the events benchmarks comparing master to 7.9.

/cc @mscdex @mcollina @nodejs/benchmarking

Metadata

Metadata

Assignees

No one assigned

    Labels

    eventsIssues and PRs related to the events subsystem / EventEmitter.performanceIssues and PRs related to the performance of Node.js.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions