Merge branch 'main' into patch-55

Author: avivkeller

.editorconfig

@@ -23,5 +23,5 @@ indent_size = unset
 indent_style = unset
 trim_trailing_whitespace = unset
 
-[{test/fixtures,deps,tools/node_modules,tools/gyp,tools/icu,tools/msvs}/**]
+[{test/fixtures,deps,tools/eslint/node_modules,tools/gyp,tools/icu,tools/msvs}/**]
 insert_final_newline = false

.github/CODEOWNERS

@@ -167,6 +167,7 @@
 /doc/api/permissions.md @nodejs/security-wg
 /lib/internal/process/permission.js @nodejs/security-wg
 /src/permission/* @nodejs/security-wg
+/test/parallel/test-permission-* @nodejs/security-wg
 
 # Dependency Update Tools
 
@@ -181,3 +182,10 @@
 /lib/internal/navigator.js @nodejs/web-standards
 /test/fixtures/wpt/ @nodejs/web-standards
 /test/wpt/ @nodejs/web-standards
+
+# TypeScript
+
+/deps/amaro/ @nodejs/typescript
+/doc/api/typescript.md @nodejs/typescript
+/test/fixtures/typescript/ @nodejs/typescript
+/tools/dep_updaters/update-amaro.sh @nodejs/typescript

.github/ISSUE_TEMPLATE/1-bug-report.yml

@@ -13,10 +13,13 @@ body:
  - type: input
  attributes:
  label: Version
- description: Output of `node -v`
- - type: input
+ description: |
+ Output of `node -v`.
+ Please verify that you are reproducing the issue in a [currently-supported version](https://github.com/nodejs/Release/blob/HEAD/README.md#release-schedule) of Node.js.
+ - type: textarea
  attributes:
  label: Platform
+ render: text
  description: |
  UNIX: output of `uname -a`
  Windows: output of `"$([Environment]::OSVersion.VersionString) $(('x86', 'x64')[[Environment]::Is64BitOperatingSystem])"` in PowerShell console
@@ -32,13 +35,19 @@ body:
  be run using `node` directly without installing third-party dependencies
  or downloading code from the internet (i.e. no ZIP archive, no GitHub
  repository, etc.).
+ validations:
+ required: true
  - type: textarea
  attributes:
  label: How often does it reproduce? Is there a required condition?
+ validations:
+ required: true
  - type: textarea
  attributes:
  label: What is the expected behavior? Why is that the expected behavior?
  description: If possible please provide textual output instead of screenshots.
+ validations:
+ required: true
  - type: textarea
  attributes:
  label: What do you see instead?

.github/label-pr-config.yml

@@ -33,6 +33,7 @@ subSystemLabels:
  /^src\/quic\/*/: c++, quic
  /^src\/node_bob*/: c++, quic
  /^src\/node_sea/: single-executable
+ /^src\/node_sqlite.*/: c++, sqlite
 
  # Properly label changes to V8 inspector integration-related files
  /^src\/inspector_/: c++, inspector, needs-ci
@@ -80,6 +81,7 @@ subSystemLabels:
  /^deps\/nghttp2\/nghttp2\.gyp/: build, http2
  /^deps\/nghttp2\//: http2
  /^deps\/ngtcp2\//: quic
+ /^deps\/amaro\//: strip-types
  /^deps\/([^/]+)/: dependencies, $1
 
  ## JS subsystems
@@ -91,12 +93,13 @@ subSystemLabels:
  /^lib\/internal\/bootstrap/: lib / src
  /^lib\/internal\/v8_prof_/: tools
  /^lib\/internal\/socket(?:_list|address)\.js$/: net
- /^lib\/\w+\/streams$/: stream
+ /^lib\/(_stream.*|internal\/streams\/.*|stream\.js|stream\/.*)$/: stream
  /^lib\/.*http2/: http2
  /^lib\/worker_threads.js$/: worker
  /^lib\/test.js$/: test_runner
  /^lib\/internal\/url\.js$/: whatwg-url
  /^lib\/internal\/modules\/esm/: esm
+ /^lib\/internal\/modules/: module
  /^lib\/internal\/webstreams/: web streams
  /^lib\/internal\/test_runner/: test_runner
 
@@ -121,6 +124,7 @@ exlusiveLabels:
  /^test\/fixtures\/es-module/: test, esm
  /^test\/es-module\//: test, esm
  /^test\/fixtures\/wpt\/streams\//: test, web streams
+ /^test\/fixtures\/typescript/: test, strip-types
 
  /^test\//: test
 
@@ -140,6 +144,8 @@ exlusiveLabels:
  # Add deprecations label to PRs that affect doc/api/deprecations.md
  /^doc\/api\/deprecations.md$/: doc, deprecations
  /^doc\/changelogs\//: release
+ # Specific map for typescript.md as it should be labeled 'strip-types'
+ /^doc\/api\/typescript.md$/: doc, strip-types
 
  /^doc\//: doc
 
@@ -186,8 +192,10 @@ allJsSubSystems:
  - readline
  - repl
  - report
+ - sqlite
  - stream
  - string_decoder
+ - strip-types
  - timers
  - tls
  - trace_events

.github/workflows/auto-start-ci.yml

@@ -45,12 +45,12 @@ jobs:
  if: needs.get-prs-for-ci.outputs.numbers != ''
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+ - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
  persist-credentials: false
 
  - name: Install Node.js
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
+ uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
  with:
  node-version: ${{ env.NODE_VERSION }}
 
@@ -59,11 +59,15 @@ jobs:
 
  - name: Setup @node-core/utils
  run: |
- ncu-config set username ${{ secrets.JENKINS_USER }}
- ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
- ncu-config set jenkins_token ${{ secrets.JENKINS_TOKEN }}
+ ncu-config set username "$USERNAME"
+ ncu-config set token "$GH_TOKEN"
+ ncu-config set jenkins_token "$JENKINS_TOKEN"
  ncu-config set owner "${{ github.repository_owner }}"
  ncu-config set repo "$(echo ${{ github.repository }} | cut -d/ -f2)"
+ env:
+ USERNAME: ${{ secrets.JENKINS_USER }}
+ GH_TOKEN: ${{ secrets.GH_USER_TOKEN }}
+ JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }}
 
  - name: Start the CI
  run: ./tools/actions/start-ci.sh ${{ needs.get-prs-for-ci.outputs.numbers }}

.github/workflows/build-tarball.yml

@@ -30,22 +30,29 @@ concurrency:
 env:
  PYTHON_VERSION: '3.12'
  FLAKY_TESTS: keep_retrying
+ CC: sccache clang
+ CXX: sccache clang++
+ SCCACHE_GHA_ENABLED: 'true'
 
 permissions:
  contents: read
 
 jobs:
  build-tarball:
  if: github.event.pull_request.draft == false
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
  steps:
- - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+ - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
+ uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
  with:
  python-version: ${{ env.PYTHON_VERSION }}
+ - name: Set up sccache
+ uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
+ with:
+ version: v0.8.0
  - name: Environment Information
  run: npx envinfo
  - name: Make tarball
@@ -57,25 +64,29 @@ jobs:
  mkdir tarballs
  mv *.tar.gz tarballs
  - name: Upload tarball artifact
- uses: actions/upload-artifact@65462800fd760344b1a7b4382951275a0abb4808 # v4.3.3
+ uses: actions/upload-artifact@0b2256b8c012f0828dc542b3febcab082c67f72b # v4.3.4
  with:
  name: tarballs
  path: tarballs
  test-tarball-linux:
  needs: build-tarball
- runs-on: ubuntu-latest
+ runs-on: ubuntu-24.04
  steps:
- - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+ - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
+ uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
  with:
  python-version: ${{ env.PYTHON_VERSION }}
+ - name: Set up sccache
+ uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
+ with:
+ version: v0.8.0
  - name: Environment Information
  run: npx envinfo
  - name: Download tarball
- uses: actions/download-artifact@65a9edc5881444af0b9093a5e628f2fe47ea3b2e # v4.1.7
+ uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
  with:
  name: tarballs
  path: tarballs
@@ -85,7 +96,7 @@ jobs:
  echo "TAR_DIR=$RUNNER_TEMP/`basename tarballs/*.tar.gz .tar.gz`" >> $GITHUB_ENV
  - name: Copy directories needed for testing
  run: |
- cp -r tools/node_modules $TAR_DIR/tools
+ cp -r tools/eslint $TAR_DIR/tools
  cp -r tools/eslint-rules $TAR_DIR/tools
  - name: Build
  run: |

.github/workflows/build-windows.yml

@@ -38,11 +38,11 @@ jobs:
  fail-fast: false
  runs-on: ${{ matrix.windows }}
  steps:
- - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+ - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
+ uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Install deps

.github/workflows/commit-lint.yml

@@ -17,13 +17,13 @@ jobs:
  run: |
  echo "plusOne=$((${{ github.event.pull_request.commits }} + 1))" >> $GITHUB_OUTPUT
  echo "minusOne=$((${{ github.event.pull_request.commits }} - 1))" >> $GITHUB_OUTPUT
- - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+ - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
  fetch-depth: ${{ steps.nb-of-commits.outputs.plusOne }}
  persist-credentials: false
  - run: git reset HEAD^2
  - name: Install Node.js
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
+ uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
  with:
  node-version: ${{ env.NODE_VERSION }}
  - name: Validate commit message

.github/workflows/commit-queue.yml

@@ -58,7 +58,7 @@ jobs:
  if: needs.get_mergeable_prs.outputs.numbers != ''
  runs-on: ubuntu-latest
  steps:
- - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+ - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
  # Needs the whole git history for ncu to work
  # See https://github.com/nodejs/node-core-utils/pull/486
@@ -71,7 +71,7 @@ jobs:
 
  # Install dependencies
  - name: Install Node.js
- uses: actions/setup-node@60edb5dd545a775178f52524783378180af0d1f8 # v4.0.2
+ uses: actions/setup-node@1e60f620b9541d16bece96c5465dc8ee9832be0b # v4.0.3
  with:
  node-version: ${{ env.NODE_VERSION }}
  - name: Install @node-core/utils
@@ -86,11 +86,15 @@ jobs:
  run: |
  ncu-config set branch ${GITHUB_REF_NAME}
  ncu-config set upstream origin
- ncu-config set username "${{ secrets.GH_USER_NAME }}"
- ncu-config set token "${{ secrets.GH_USER_TOKEN }}"
- ncu-config set jenkins_token "${{ secrets.JENKINS_TOKEN }}"
+ ncu-config set username "$USERNAME"
+ ncu-config set token "$GH_TOKEN"
+ ncu-config set jenkins_token "$JENKINS_TOKEN"
  ncu-config set repo "${REPOSITORY}"
  ncu-config set owner "${OWNER}"
+ env:
+ USERNAME: ${{ secrets.JENKINS_USER }}
+ GH_TOKEN: ${{ secrets.GH_USER_TOKEN }}
+ JENKINS_TOKEN: ${{ secrets.JENKINS_TOKEN }}
 
  - name: Start the Commit Queue
  run: ./tools/actions/commit-queue.sh ${{ env.OWNER }} ${{ env.REPOSITORY }} ${{ needs.get_mergeable_prs.outputs.numbers }}

.github/workflows/coverage-linux-without-intl.yml

@@ -12,6 +12,7 @@ on:
  - tools/gyp/**
  - tools/test.py
  - .github/workflows/coverage-linux-without-intl.yml
+ - codecov.yml
  push:
  branches:
  - main
@@ -24,6 +25,7 @@ on:
  - tools/gyp/**
  - tools/test.py
  - .github/workflows/coverage-linux-without-intl.yml
+ - codecov.yml
 
 concurrency:
  group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
@@ -32,34 +34,33 @@ concurrency:
 env:
  PYTHON_VERSION: '3.12'
  FLAKY_TESTS: keep_retrying
+ CC: sccache clang
+ CXX: sccache clang++
+ SCCACHE_GHA_ENABLED: 'true'
 
 permissions:
  contents: read
 
 jobs:
  coverage-linux-without-intl:
  if: github.event.pull_request.draft == false
- runs-on: ubuntu-latest
- env:
- CC: sccache gcc
- CXX: sccache g++
- SCCACHE_GHA_ENABLED: 'true'
+ runs-on: ubuntu-24.04
  steps:
- - uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+ - uses: actions/checkout@692973e3d937129bcbf40652eb9f2f61becf3332 # v4.1.7
  with:
  persist-credentials: false
  - name: Set up Python ${{ env.PYTHON_VERSION }}
- uses: actions/setup-python@82c7e631bb3cdc910f68e0081d67478d79c6982d # v5.1.0
+ uses: actions/setup-python@39cd14951b08e74b54015e9e001cdefcf80e669f # v5.1.1
  with:
  python-version: ${{ env.PYTHON_VERSION }}
  - name: Set up sccache
- uses: mozilla-actions/sccache-action@2e7f9ec7921547d4b46598398ca573513895d0bd # v0.0.4
+ uses: mozilla-actions/sccache-action@89e9040de88b577a072e3760aaf59f585da083af # v0.0.5
  with:
  version: v0.8.0
  - name: Environment Information
  run: npx envinfo
  - name: Install gcovr
- run: pip install gcovr==4.2
+ run: pip install gcovr==7.2
  - name: Build
  run: make build-ci -j4 V=1 CONFIG_FLAGS="--error-on-warn --coverage --without-intl"
  # TODO(bcoe): fix the couple tests that fail with the inspector enabled.
@@ -71,12 +72,12 @@ jobs:
  env:
  NODE_OPTIONS: --max-old-space-size=8192
  - name: Report C++
- run: cd out && gcovr --gcov-exclude='.*\b(deps|usr|out|obj|cctest|embedding)\b' -v -r Release/obj.target --xml -o ../coverage/coverage-cxx.xml --root=$(cd ../ && pwd)
+ run: gcovr --object-directory=out -v --filter src --xml -o ./coverage/coverage-cxx.xml --root=./ --gcov-executable="llvm-cov-18 gcov"
  # Clean temporary output from gcov and c8, so that it's not uploaded:
  - name: Clean tmp
  run: rm -rf coverage/tmp && rm -rf out
  - name: Upload
- uses: codecov/codecov-action@125fc84a9a348dbcf27191600683ec096ec9021c # v4.4.1
+ uses: codecov/codecov-action@e28ff129e5465c2c0dcc6f003fc735cb6ae0c673 # v4.5.0
  with:
  directory: ./coverage
  token: ${{ secrets.CODECOV_TOKEN }}