timers: Optimize timer functions with improved argument handling

Author: gurgunday

lib/timers.js

@@ -22,6 +22,7 @@
 'use strict';
 
 const {
+ Array,
  ArrayPrototypePush,
  MathTrunc,
  ObjectDefineProperties,
@@ -121,7 +122,7 @@ function unenroll(item) {
 function setTimeout(callback, after, arg1, arg2, arg3) {
  validateFunction(callback, 'callback');
 
- let i, args;
+ let args;
  switch (arguments.length) {
  // fast cases
  case 1:
@@ -134,10 +135,9 @@ function setTimeout(callback, after, arg1, arg2, arg3) {
  args = [arg1, arg2];
  break;
  default:
- args = [arg1, arg2, arg3];
- for (i = 5; i < arguments.length; i++) {
- // Extend array dynamically, makes .apply run much faster in v6.0.0
- ArrayPrototypePush(args, arguments[i]);
+ args = new Array(arguments.length - 2);
+ for (let i = 2; i < arguments.length; i++) {
+ args[i - 2] = arguments[i];
  }
  break;
  }
@@ -190,7 +190,7 @@ function clearTimeout(timer) {
 function setInterval(callback, repeat, arg1, arg2, arg3) {
  validateFunction(callback, 'callback');
 
- let i, args;
+ let args;
  switch (arguments.length) {
  // fast cases
  case 1:
@@ -203,10 +203,9 @@ function setInterval(callback, repeat, arg1, arg2, arg3) {
  args = [arg1, arg2];
  break;
  default:
- args = [arg1, arg2, arg3];
- for (i = 5; i < arguments.length; i++) {
- // Extend array dynamically, makes .apply run much faster in v6.0.0
- ArrayPrototypePush(args, arguments[i]);
+ args = new Array(arguments.length - 2);
+ for (let i = 2; i < arguments.length; i++) {
+ args[i - 2] = arguments[i];
  }
  break;
  }
@@ -263,7 +262,7 @@ Timeout.prototype[SymbolToPrimitive] = function() {
 function setImmediate(callback, arg1, arg2, arg3) {
  validateFunction(callback, 'callback');
 
- let i, args;
+ let args;
  switch (arguments.length) {
  // fast cases
  case 1:
@@ -275,10 +274,9 @@ function setImmediate(callback, arg1, arg2, arg3) {
  args = [arg1, arg2];
  break;
  default:
- args = [arg1, arg2, arg3];
- for (i = 4; i < arguments.length; i++) {
- // Extend array dynamically, makes .apply run much faster in v6.0.0
- ArrayPrototypePush(args, arguments[i]);
+ args = new Array(arguments.length - 1);
+ for (let i = 1; i < arguments.length; i++) {
+ args[i - 1] = arguments[i];
  }
  break;
  }