http: check for existance in resetHeadersTimeoutOnReqEnd

socket.parser can be undefined under unknown circumstances. This is a fix for a bug I cannot reproduce but it is affecting people. Fixes: #26366 PR-URL: #26402 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: mcollina

lib/_http_server.js

@@ -741,7 +741,7 @@ function resetHeadersTimeoutOnReqEnd() {
  const parser = this.socket.parser;
  // Parser can be null if the socket was destroyed
  // in that case, there is nothing to do.
- if (parser !== null) {
+ if (parser) {
  parser.parsingHeadersStart = nowDate();
  }
 }

test/parallel/test-http-server-delete-parser.js

@@ -0,0 +1,24 @@
+'use strict';
+
+const common = require('../common');
+
+const http = require('http');
+
+const server = http.createServer(common.mustCall((req, res) => {
+ res.writeHead(200, { 'Content-Type': 'text/plain' });
+ res.write('okay', common.mustCall(() => {
+ delete res.socket.parser;
+ }));
+ res.end();
+}));
+
+server.listen(1337, '127.0.0.1');
+server.unref();
+
+const req = http.request({
+ port: 1337,
+ host: '127.0.0.1',
+ method: 'GET',
+});
+
+req.end();