path,win: fix bug in resolve

Fixes: #54025

Author: huseyinacacak-janea

lib/path.js

@@ -263,11 +263,17 @@ const win32 = {
  !isPathSeparator(StringPrototypeCharCodeAt(path, j))) {
  j++;
  }
- if (j === len || j !== last) {
- // We matched a UNC root
- device =
- `\\\\${firstPart}\\${StringPrototypeSlice(path, last, j)}`;
- rootEnd = j;
+ if ((j === len || j !== last)) {
+ if (firstPart !== '.' && firstPart !== '?') {
+ // We matched a UNC root
+ device =
+ `\\\\${firstPart}\\${StringPrototypeSlice(path, last, j)}`;
+ rootEnd = j;
+ } else {
+ // We matched a device root (e.g. \\\\.\\PHYSICALDRIVE0)
+ device = `\\\\${firstPart}`;
+ rootEnd = 4;
+ }
  }
  }
  }

src/path.cc

@@ -169,10 +169,17 @@ std::string PathResolve(Environment* env,
  while (j < len && !IsPathSeparator(path[j])) {
  j++;
  }
- if (j == len || j != last) {
- // We matched a UNC root
- device = "\\\\" + firstPart + "\\" + path.substr(last, j - last);
- rootEnd = j;
+ if ((j == len || j != last)) {
+ if (firstPart != "." && firstPart != "?") {
+ // We matched a UNC root
+ device =
+ "\\\\" + firstPart + "\\" + path.substr(last, j - last);
+ rootEnd = j;
+ } else {
+ // We matched a device root (e.g. \\\\.\\PHYSICALDRIVE0)
+ device = "\\\\" + firstPart;
+ rootEnd = 4;
+ }
  }
  }
  }

test/cctest/test_path.cc

@@ -39,6 +39,10 @@ TEST_F(PathTest, PathResolve) {
  EXPECT_EQ(
  PathResolve(*env, {"C:\\foo\\tmp.3\\", "..\\tmp.3\\cycles\\root.js"}),
  "C:\\foo\\tmp.3\\cycles\\root.js");
+ EXPECT_EQ(PathResolve(*env, {"\\\\.\\PHYSICALDRIVE0"}),
+ "\\\\.\\PHYSICALDRIVE0");
+ EXPECT_EQ(PathResolve(*env, {"\\\\?\\PHYSICALDRIVE0"}),
+ "\\\\?\\PHYSICALDRIVE0");
 #else
  EXPECT_EQ(PathResolve(*env, {"/var/lib", "../", "file/"}), "/var/file");
  EXPECT_EQ(PathResolve(*env, {"/var/lib", "/../", "file/"}), "/file");

test/parallel/test-path-makelong.js

@@ -79,7 +79,7 @@ assert.strictEqual(path.win32.toNamespacedPath('\\\\foo\\bar'),
  '\\\\?\\UNC\\foo\\bar\\');
 assert.strictEqual(path.win32.toNamespacedPath('//foo//bar'),
  '\\\\?\\UNC\\foo\\bar\\');
-assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'), '\\\\?\\foo\\');
+assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\foo'), '\\\\?\\foo');
 assert.strictEqual(path.win32.toNamespacedPath('\\\\?\\c:\\Windows/System'), '\\\\?\\c:\\Windows\\System');
 assert.strictEqual(path.win32.toNamespacedPath(null), null);
 assert.strictEqual(path.win32.toNamespacedPath(true), true);

test/parallel/test-path-resolve.js

@@ -33,6 +33,8 @@ const resolveTests = [
  [['c:/', '///some//dir'], 'c:\\some\\dir'],
  [['C:\\foo\\tmp.3\\', '..\\tmp.3\\cycles\\root.js'],
  'C:\\foo\\tmp.3\\cycles\\root.js'],
+ [['\\\\.\\PHYSICALDRIVE0'], '\\\\.\\PHYSICALDRIVE0'],
+ [['\\\\?\\PHYSICALDRIVE0'], '\\\\?\\PHYSICALDRIVE0'],
  ],
  ],
  [ path.posix.resolve,