module: load source maps in commonjs translator

Author: privatenumber

lib/internal/modules/esm/translators.js

@@ -289,6 +289,8 @@ function createCJSModuleWrap(url, source, isMain, loadCJS = loadCJSModule) {
  // In case the source was not provided by the `load` step, we need fetch it now.
  source = stringify(source ?? getSource(new URL(url)).source);
 
+ maybeCacheSourceMap(url, source);
+
  const { exportNames, module } = cjsPreparseModuleExports(filename, source);
  cjsCache.set(url, module);
  const namesWithDefault = exportNames.has('default') ?

test/es-module/test-esm-loader-hooks.mjs

@@ -747,6 +747,30 @@ describe('Loader hooks', { concurrency: true }, () => {
  assert.strictEqual(signal, null);
  });
 
+ it('should support source maps in commonjs translator', async () => {
+ const readFile = async () => {};
+ const fileURLToPath = () => {};
+ const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
+ '--no-warnings',
+ '--enable-source-maps',
+ '--experimental-loader',
+ `data:text/javascript,import{readFile}from"node:fs/promises";import{fileURLToPath}from"node:url";export ${
+ async function load(u, c, n) {
+ const r = await n(u, c);
+ if (c.format === 'commonjs') {
+ r.source = await readFile(new URL(u));
+ }
+ return r;
+ }}`,
+ fixtures.path('source-map/throw-on-require.js'),
+ ]);
+
+ assert.strictEqual(stdout, '');
+ assert.match(stderr, /throw-on-require\.ts:9:9/);
+ assert.strictEqual(code, 1);
+ assert.strictEqual(signal, null);
+ });
+
  it('should handle mixed of opt-in modules and non-opt-in ones', async () => {
  const { code, signal, stdout, stderr } = await spawnPromisified(execPath, [
  '--no-warnings',