fs: fix dereference: false on cpSync

Author: npaun

src/node_file.cc

@@ -3245,8 +3245,8 @@ static void CpSyncCheckPaths(const FunctionCallbackInfo<Value>& args) {
  errorno, dereference ? "stat" : "lstat", nullptr, src.out());
  }
  auto dest_status =
- dereference ? std::filesystem::symlink_status(dest_path, error_code)
- : std::filesystem::status(dest_path, error_code);
+ dereference ? std::filesystem::status(dest_path, error_code)
+ : std::filesystem::symlink_status(dest_path, error_code);
 
  bool dest_exists = !error_code && dest_status.type() !=
  std::filesystem::file_type::not_found;

test/known_issues/test-fs-cp-sync-dereference.js renamed to test/parallel/test-fs-cp-sync-dereference.js

@@ -15,25 +15,38 @@ const {
  mkdirSync,
  symlinkSync,
  writeFileSync,
+ readFileSync,
+ statSync
 } = require('fs');
 
 const {
  join,
 } = require('path');
 
+const assert = require('assert/strict');
+
 const tmpdir = require('../common/tmpdir');
 tmpdir.refresh();
 
-const pathA = join(tmpdir.path, 'a');
-const pathB = join(tmpdir.path, 'b');
-const pathC = join(tmpdir.path, 'c');
-const pathD = join(tmpdir.path, 'd');
+const pathA = join(tmpdir.path, 'a'); // file
+const pathB = join(tmpdir.path, 'b'); // directory
+const pathC = join(tmpdir.path, 'c'); // c -> b
+const pathD = join(tmpdir.path, 'd'); // d -> b
 
 writeFileSync(pathA, 'file a');
 mkdirSync(pathB);
 symlinkSync(pathB, pathC, 'dir');
 symlinkSync(pathB, pathD, 'dir');
 
-cp(pathA, pathD, { dereference: false }, common.mustSucceed());
+cp(pathA, pathD, { dereference: false }, common.mustSucceed(() => {
+ // d is now a file, not a symlink
+ assert.strictEqual(readFileSync(pathA, 'utf-8'), readFileSync(pathD, 'utf-8'));
+ assert.ok(statSync(pathA).isFile());
+ assert.ok(statSync(pathD).isFile());
+}));
 
 cpSync(pathA, pathC, { dereference: false });
+
+assert.strictEqual(readFileSync(pathA, 'utf-8'), readFileSync(pathC, 'utf-8'));
+assert.ok(statSync(pathA).isFile());
+assert.ok(statSync(pathC).isFile());