crypto: fix DiffieHellman generator validation

PR-URL: #38311 Fixes: #38302 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>

Author: eladkishon

lib/internal/crypto/diffiehellman.js

@@ -122,9 +122,9 @@ function DiffieHellman(sizeOrKey, keyEncoding, generator, genEncoding) {
  generator = DH_GENERATOR;
  } else if (typeof generator === 'number') {
  validateInt32(generator, 'generator');
- } else if (generator !== true) {
+ } else if (typeof generator === 'string') {
  generator = toBuf(generator, genEncoding);
- } else {
+ } else if (!isArrayBufferView(generator) && !isAnyArrayBuffer(generator)) {
  throw new ERR_INVALID_ARG_TYPE(
  'generator',
  ['number', 'string', 'ArrayBuffer', 'Buffer', 'TypedArray', 'DataView'],

test/parallel/test-crypto-dh.js

@@ -495,3 +495,7 @@ assert.throws(
  code: 'ERR_INVALID_ARG_TYPE'
  }
 );
+[true, Symbol(), {}, () => {}, []].forEach((generator) => assert.throws(
+ () => crypto.createDiffieHellman('', 'base64', generator),
+ { code: 'ERR_INVALID_ARG_TYPE' }
+));