inspector: perform DNS lookup for host

PR-URL: #13478 Fixes: #13477 Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>

Author: Eugene Ostroukhov

src/inspector_agent.cc

@@ -702,13 +702,7 @@ void Url(const FunctionCallbackInfo<Value>& args) {
 
  if (ids.empty()) return;
 
- std::string url = "ws://";
- url += io->host();
- url += ":";
- url += std::to_string(io->port());
- url += "/";
- url += ids[0];
-
+ std::string url = FormatWsAddress(io->host(), io->port(), ids[0], true);
  args.GetReturnValue().Set(OneByteString(env->isolate(), url.c_str()));
 }
 

src/inspector_io.cc

@@ -313,7 +313,7 @@ void InspectorIo::ThreadMain() {
  uv_sem_post(&thread_start_sem_);
  return;
  }
- port_ = server.port(); // Safe, main thread is waiting on semaphore.
+ port_ = server.Port(); // Safe, main thread is waiting on semaphore.
  if (!wait_for_connect_) {
  uv_sem_post(&thread_start_sem_);
  }

src/inspector_io.h

@@ -28,6 +28,10 @@ class StringView;
 namespace node {
 namespace inspector {
 
+std::string FormatWsAddress(const std::string& host, int port,
+ const std::string& target_id,
+ bool include_protocol);
+
 class InspectorIoDelegate;
 
 enum class InspectorAction {

src/inspector_socket.h

@@ -63,6 +63,7 @@ class InspectorSocket {
  bool ws_mode;
  bool shutting_down;
  bool connection_eof;
+
  private:
  DISALLOW_COPY_AND_ASSIGN(InspectorSocket);
 };