sqlite: reset statement immediately in run()

This commit updates StatementSync.prototype.run() to reset the prepared statement immediately after calling sqlite3_step() to return the correct change metadata. Fixes: #57344 PR-URL: #57350 Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Jake Yuesong Li <jake.yuesong@gmail.com>

Author: cjihrig

src/node_sqlite.cc

@@ -1887,13 +1887,9 @@ void StatementSync::Run(const FunctionCallbackInfo<Value>& args) {
  return;
  }
 
- auto reset = OnScopeLeave([&]() { sqlite3_reset(stmt->statement_); });
- r = sqlite3_step(stmt->statement_);
- if (r != SQLITE_ROW && r != SQLITE_DONE) {
- THROW_ERR_SQLITE_ERROR(env->isolate(), stmt->db_.get());
- return;
- }
-
+ sqlite3_step(stmt->statement_);
+ r = sqlite3_reset(stmt->statement_);
+ CHECK_ERROR_OR_THROW(env->isolate(), stmt->db_.get(), r, SQLITE_OK, void());
  Local<Object> result = Object::New(env->isolate());
  sqlite3_int64 last_insert_rowid =
  sqlite3_last_insert_rowid(stmt->db_->Connection());

test/parallel/test-sqlite-statement-sync.js

@@ -169,6 +169,25 @@ suite('StatementSync.prototype.run()', () => {
  errstr: 'constraint failed',
  });
  });
+
+ test('returns correct metadata when using RETURNING', (t) => {
+ const db = new DatabaseSync(':memory:');
+ const setup = db.exec(
+ 'CREATE TABLE data(key INTEGER PRIMARY KEY, val INTEGER NOT NULL) STRICT;'
+ );
+ t.assert.strictEqual(setup, undefined);
+ const sql = 'INSERT INTO data (key, val) VALUES ($k, $v) RETURNING key';
+ const stmt = db.prepare(sql);
+ t.assert.deepStrictEqual(
+ stmt.run({ k: 1, v: 10 }), { changes: 1, lastInsertRowid: 1 }
+ );
+ t.assert.deepStrictEqual(
+ stmt.run({ k: 2, v: 20 }), { changes: 1, lastInsertRowid: 2 }
+ );
+ t.assert.deepStrictEqual(
+ stmt.run({ k: 3, v: 30 }), { changes: 1, lastInsertRowid: 3 }
+ );
+ });
 });
 
 suite('StatementSync.prototype.sourceSQL', () => {