squash: inspect property names, allow non-objects

Author: LiviaMedeiros

test/common/index.js

@@ -522,32 +522,33 @@ function mustNotCall(msg) {
 const _mustNotMutateProxies = new WeakMap();
 
 function mustNotMutate(object) {
+ if (object === null || typeof object !== 'object')
+ return object;
+
  const cachedProxy = _mustNotMutateProxies.get(object);
  if (cachedProxy) {
  return cachedProxy;
  }
 
  const _mustNotMutateHandler = {
  defineProperty(target, property, descriptor) {
- assert.fail(`Expected no side effects, got ${property} defined`);
+ assert.fail(`Expected no side effects, got ${util.inspect(property)} ` +
+ 'defined');
  },
  deleteProperty(target, property) {
- assert.fail(`Expected no side effects, got ${property} deleted`);
+ assert.fail(`Expected no side effects, got ${util.inspect(property)} ` +
+ 'deleted');
  },
  get(target, prop, receiver) {
- const value = Reflect.get(target, prop, receiver);
- if (value === null || typeof value !== 'object') {
- return value;
- }
- return mustNotMutate(value);
+ return mustNotMutate(Reflect.get(target, prop, receiver));
  },
  preventExtensions(target) {
  assert.fail('Expected no side effects, got extensions prevented on ' +
  util.inspect(target));
  },
  set(target, property, value, receiver) {
  assert.fail(`Expected no side effects, got ${util.inspect(value)} ` +
- `assigned to ${property}`);
+ `assigned to ${util.inspect(property)}`);
  },
  setPrototypeOf(target, prototype) {
  assert.fail(`Expected no side effects, got set prototype to ${prototype}`);