build: remove node_report option in node.gyp

PR-URL: #32242 Fixes: #26293 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Author: cjihrig

node.gyp

@@ -336,6 +336,8 @@
  'type': 'executable',
 
  'defines': [
+ 'NODE_ARCH="<(target_arch)"',
+ 'NODE_PLATFORM="<(OS)"',
  'NODE_WANT_INTERNALS=1',
  ],
 
@@ -423,13 +425,6 @@
  'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
  },
  }],
- [ 'node_report=="true"', {
- 'defines': [
- 'NODE_REPORT',
- 'NODE_ARCH="<(target_arch)"',
- 'NODE_PLATFORM="<(OS)"',
- ],
- }],
  ['OS=="win"', {
  'libraries': [
  'Dbghelp.lib',
@@ -595,6 +590,9 @@
  'src/node_process_events.cc',
  'src/node_process_methods.cc',
  'src/node_process_object.cc',
+ 'src/node_report.cc',
+ 'src/node_report_module.cc',
+ 'src/node_report_utils.cc',
  'src/node_serdes.cc',
  'src/node_sockaddr.cc',
  'src/node_stat_watcher.cc',
@@ -684,6 +682,7 @@
  'src/node_perf_common.h',
  'src/node_platform.h',
  'src/node_process.h',
+ 'src/node_report.h',
  'src/node_revert.h',
  'src/node_root_certs.h',
  'src/node_sockaddr.h',
@@ -780,6 +779,7 @@
  'libraries': [
  'Dbghelp',
  'Psapi',
+ 'Ws2_32',
  ],
  }],
  [ 'node_use_etw=="true"', {
@@ -864,23 +864,6 @@
  'src/tls_wrap.h'
  ],
  }],
- [ 'node_report=="true"', {
- 'sources': [
- 'src/node_report.cc',
- 'src/node_report_module.cc',
- 'src/node_report_utils.cc',
- ],
- 'defines': [
- 'NODE_REPORT',
- 'NODE_ARCH="<(target_arch)"',
- 'NODE_PLATFORM="<(OS)"',
- ],
- 'conditions': [
- ['OS=="win"', {
- 'libraries': [ 'Ws2_32' ],
- }],
- ],
- }],
  [ 'OS in "linux freebsd mac" and '
  'target_arch=="x64" and '
  'node_target_type=="executable"', {
@@ -1137,7 +1120,11 @@
  'test/cctest',
  ],
 
- 'defines': [ 'NODE_WANT_INTERNALS=1' ],
+ 'defines': [
+ 'NODE_ARCH="<(target_arch)"',
+ 'NODE_PLATFORM="<(OS)"',
+ 'NODE_WANT_INTERNALS=1',
+ ],
 
  'sources': [
  'src/node_snapshot_stub.cc',
@@ -1154,6 +1141,7 @@
  'test/cctest/test_linked_binding.cc',
  'test/cctest/test_per_process.cc',
  'test/cctest/test_platform.cc',
+ 'test/cctest/test_report_util.cc',
  'test/cctest/test_sockaddr.cc',
  'test/cctest/test_traced_value.cc',
  'test/cctest/test_util.cc',
@@ -1191,21 +1179,6 @@
  'OTHER_LDFLAGS': [ '-Wl,-rpath,@loader_path', ],
  },
  }],
- [ 'node_report=="true"', {
- 'sources': [
- 'test/cctest/test_report_util.cc',
- ],
- 'defines': [
- 'NODE_REPORT',
- 'NODE_ARCH="<(target_arch)"',
- 'NODE_PLATFORM="<(OS)"',
- ],
- 'conditions': [
- ['OS=="win"', {
- 'libraries': [ 'Ws2_32' ],
- }],
- ],
- }],
  ['OS=="win"', {
  'libraries': [
  'Dbghelp.lib',