url: ignore IDN errors when domainname have hyphens

There are valid domain names with hyphens at 3 and 4th position, new node WHATWG URL parser was failing for it assume its an invalid IDN. Also filters IDN errors when domain label start or end with hyphen. Fixes: #12965 Refs: https://www.icann.org/news/announcement-2000-01-07-en

Author: zimbabao

src/node_i18n.cc

@@ -472,8 +472,8 @@ int32_t ToUnicode(MaybeStackBuffer<char>* buf,
  // 9.0.0 (rev. 17), but were found to be incompatible with many actual domain
  // names in the wild. As such, in the current UTS #46 draft (rev. 18) these
  // checks are made optional depending on the CheckHyphens flag, which will be
- // disabled in WHATWG URL's "domain to ASCII" algorithm as soon as the UTS #46
- // draft becomes standard.
+ // disabled in WHATWG URL's "domain to unicode" algorithm as soon as the UTS
+ // #46 draft becomes standard.
  // Refs:
  // - https://github.com/whatwg/url/issues/53
  // - http://www.unicode.org/review/pri317/

test/fixtures/url-idna.js

@@ -204,6 +204,14 @@ module.exports = {
  {
  ascii: 'sn-a5mlrn7s-.gevideo.com',
  unicode: 'sn-a5mlrn7s-.gevideo.com'
+ },
+ {
+ ascii: '-sn-a5mlrn7s-.gevideo.com',
+ unicode: '-sn-a5mlrn7s-.gevideo.com'
+ },
+ {
+ ascii: '-sn--a5mlrn7s-.gevideo.com',
+ unicode: '-sn--a5mlrn7s-.gevideo.com'
  }
  ],
  invalid: [