string_decoder: throw ERR_STRING_TOO_LONG for UTF-8

String::NewFromUtf8 doesn't generate an exception in V8 when the string is too long but is guaranteed to return an empty MaybeLocal only in that case. Generate a Node.js exception when it happens. Fixes: #35676 PR-URL: #36661 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Author: targos

src/string_decoder.cc

@@ -3,6 +3,7 @@
 
 #include "env-inl.h"
 #include "node_buffer.h"
+#include "node_errors.h"
 #include "string_bytes.h"
 #include "util.h"
 
@@ -29,11 +30,17 @@ MaybeLocal<String> MakeString(Isolate* isolate,
  Local<Value> error;
  MaybeLocal<Value> ret;
  if (encoding == UTF8) {
- return String::NewFromUtf8(
+ MaybeLocal<String> utf8_string = String::NewFromUtf8(
  isolate,
  data,
  v8::NewStringType::kNormal,
  length);
+ if (utf8_string.IsEmpty()) {
+ isolate->ThrowException(node::ERR_STRING_TOO_LONG(isolate));
+ return MaybeLocal<String>();
+ } else {
+ return utf8_string;
+ }
  } else {
  ret = StringBytes::Encode(
  isolate,

test/parallel/test-string-decoder.js

@@ -201,6 +201,13 @@ assert.throws(
  }
 );
 
+assert.throws(
+ () => new StringDecoder().write(Buffer.alloc(0x1fffffe8 + 1).fill('a')),
+ {
+ code: 'ERR_STRING_TOO_LONG',
+ }
+);
+
 // Test verifies that StringDecoder will correctly decode the given input
 // buffer with the given encoding to the expected output. It will attempt all
 // possible ways to write() the input buffer, see writeSequences(). The