test_runner: refactor build Promise in Suite()

This commit refactors the buildSuite Promise logic in the Suite constructor to use an async function instead of creating an awkward primordial-based Promise chain.

Author: cjihrig

lib/internal/test_runner/test.js

@@ -24,7 +24,6 @@ const {
  SafeMap,
  SafePromiseAll,
  SafePromiseAllReturnVoid,
- SafePromisePrototypeFinally,
  SafePromiseRace,
  SafeSet,
  StringPrototypeStartsWith,
@@ -1258,27 +1257,20 @@ class Suite extends Test {
  this.skipped = false;
  }
 
+ this.buildSuite = this.createBuild();
+ this.fn = noop;
+ }
+
+ async createBuild() {
  try {
  const { ctx, args } = this.getRunArgs();
  const runArgs = [this.fn, ctx];
  ArrayPrototypePushApply(runArgs, args);
- this.buildSuite = SafePromisePrototypeFinally(
- PromisePrototypeThen(
- PromiseResolve(ReflectApply(this.runInAsyncScope, this, runArgs)),
- undefined,
- (err) => {
- this.fail(new ERR_TEST_FAILURE(err, kTestCodeFailure));
- }),
- () => this.postBuild(),
- );
+ await ReflectApply(this.runInAsyncScope, this, runArgs);
  } catch (err) {
  this.fail(new ERR_TEST_FAILURE(err, kTestCodeFailure));
- this.postBuild();
  }
- this.fn = noop;
- }
 
- postBuild() {
  this.buildPhaseFinished = true;
  }