Skip to content

Conversation

@jmastr
Copy link

@jmastr jmastr commented Nov 2, 2016

If an application in a container requires HTTPS, one needs to set the
'proxy_path https://...' instead of 'proxy_pass http://...'. With this
patch one can use the annotation:

'nginx.org/ssl-services: "service1[,service2,...]"'

to specify, which services require HTTPS.

Fixes #61

@pleshakov
Copy link
Contributor

Hi @jmastr
Thanks for the pull request! Looks good!

I have a few small suggestions:

  1. Could you rename the annotation from nginx.org/ssl-backends to nginx.org/ssl-services? This will make the naming consistent: we already have nginx.org/websocket-services and nginx.com/sticky-cookie-services. My bad suggesting the wrong name in proxy_pass hard-coded to HTTP #61
  2. As a consequence of renaming, please rename the example folder to ssl-services, the title of the README.md to SSL Services Support, the name of the service from ssl-backend-svc to ssl-svc.
  3. Could you also replace an application speaking HTTPS with an application that requires HTTPS , one of which is speaking SSL with one of which requires HTTPS and is a service for the SSL backend application with is a service for an HTTPS application
@jmastr jmastr force-pushed the jmastr/add_ssl_backends branch from 9afab33 to ee3110d Compare November 3, 2016 07:23
If an application in a container requires HTTPS, one needs to set the 'proxy_path https://...' instead of 'proxy_pass http://...'. With this patch one can use the annotation: 'nginx.org/ssl-services: "service1[,service2,...]"' to specify, which services require HTTPS. Fixes nginx#61
@jmastr jmastr force-pushed the jmastr/add_ssl_backends branch from ee3110d to 8354d4e Compare November 3, 2016 07:24
@jmastr jmastr changed the title Add SSL backend annotation Add SSL services annotation Nov 3, 2016
@jmastr
Copy link
Author

jmastr commented Nov 3, 2016

@pleshakov done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants