Skip to content

Add worker-shutdown-timeout configmap key #208

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 2, 2017
Merged

Add worker-shutdown-timeout configmap key #208

merged 1 commit into from
Nov 2, 2017

Conversation

@Sarga
Copy link
Contributor

@Sarga Sarga commented Nov 1, 2017

No description provided.

@pleshakov
Copy link
Contributor

pleshakov commented Nov 1, 2017

@Sarga thx! Looks good!

  • Could you set the WorkerShutdownTimeout with some value here in the templates_test.go? The tests in that file make sure that the templates are executed without any errors.
  • Could you squash your commits into a single one?
@Sarga
Copy link
Contributor Author

Sarga commented Nov 1, 2017

@pleshakov done. Thanks for the advice!
@pleshakov pleshakov merged commit cfddc11 into nginx:master Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@Sarga @pleshakov