Skip to content

Conversation

@AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented May 14, 2025

Proposed changes

  • Add note to the Tech Specs to notify users of the upcoming removal of 3 architechures: armv7, s390x & ppc64le

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
@AlexFenlon AlexFenlon requested review from a team as code owners May 14, 2025 11:21
@AlexFenlon AlexFenlon added the needs cherry pick Cherry pick this PR into a release branch label May 14, 2025
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label May 14, 2025
@github-actions
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7782/

ADubhlaoich
ADubhlaoich previously approved these changes May 14, 2025
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM: suggestions for re-phrasing.

Co-authored-by: Alan Dooley <a.dooley@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
@AlexFenlon
Copy link
Contributor Author

AlexFenlon commented May 14, 2025

removing the release notes as we already have a notice here

Signed-off-by: AlexFenlon <a.fenlon@f5.com>
@AlexFenlon AlexFenlon changed the title Add note to release notes and Tech Specs about removal of archs Add note to the Tech Specs about removal of archs May 14, 2025
@AlexFenlon AlexFenlon merged commit a0fd424 into main May 14, 2025
30 checks passed
@AlexFenlon AlexFenlon deleted the docs/update-tech-spec-archs branch May 14, 2025 12:58
@AlexFenlon AlexFenlon removed the needs cherry pick Cherry pick this PR into a release branch label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

5 participants