Skip to content

Conversation

@AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Apr 14, 2025

Proposed changes

update the zone-sync note to have better wording and clearer instruction.

Screenshot 2025-04-14 at 12 03 06

Similar note will be added to next release notes

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
@AlexFenlon AlexFenlon requested review from a team as code owners April 14, 2025 10:58
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Apr 14, 2025
@AlexFenlon AlexFenlon changed the title Update zone sync note Update the zone-sync ConfigMap note Apr 14, 2025
@AlexFenlon AlexFenlon changed the title Update the zone-sync ConfigMap note Update the zone-sync ConfigMap key note Apr 14, 2025
@github-actions
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7641/

@AlexFenlon AlexFenlon added the needs cherry pick Cherry pick this PR into a release branch label Apr 14, 2025
Copy link
Contributor

@mjang mjang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm making and pushing grammar and style changes before pushing.

Signed-off-by: Mike Jang <3287976+mjang@users.noreply.github.com>
@mjang mjang enabled auto-merge (squash) April 14, 2025 13:21
@mjang mjang merged commit 9a8c15d into main Apr 14, 2025
30 checks passed
@mjang mjang deleted the update-zone-sync-note branch April 14, 2025 13:22
nginx-bot pushed a commit that referenced this pull request Apr 14, 2025
Signed-off-by: Mike Jang <3287976+mjang@users.noreply.github.com> --------- Signed-off-by: Mike Jang <3287976+mjang@users.noreply.github.com> Co-authored-by: Mike Jang <3287976+mjang@users.noreply.github.com>
@AlexFenlon AlexFenlon moved this from Todo ☑ to Done 🚀 in NGINX Ingress Controller Apr 15, 2025
@AlexFenlon AlexFenlon self-assigned this Apr 15, 2025
@AlexFenlon AlexFenlon removed the needs cherry pick Cherry pick this PR into a release branch label Jun 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

6 participants