- Notifications
You must be signed in to change notification settings - Fork 2k
Add zone-sync ConfigMap Keys to docs #7434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview will be available once build job completes!
|
javorszky left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do these new options have default values? If I don't set a zone-sync-resolver-valid option, what's the TTL going to be?
What's the default for the ipv6?
site/content/configuration/global-configuration/configmap-resource.md Outdated Show resolved Hide resolved
…urce.md Co-authored-by: Gabor Javorszky <g.javorszky@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
Yes, these new options have default values, IF zone-sync is set and only if zone-sync is set. the default for IPV6 on/true as it is it also nginx's default here. the default config is below if the user has |
jjngx left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
site/content/configuration/global-configuration/configmap-resource.md Outdated Show resolved Hide resolved
…urce.md Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
site/content/configuration/global-configuration/configmap-resource.md Outdated Show resolved Hide resolved
…urce.md Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
Signed-off-by: AlexFenlon <a.fenlon@f5.com>
ADubhlaoich left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM but please look at my edit suggestions.
site/content/configuration/global-configuration/configmap-resource.md Outdated Show resolved Hide resolved
Co-authored-by: Alan Dooley <a.dooley@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>

Proposed changes
Resolves: #7277
Checklist
Before creating a PR, run through this checklist and mark each as complete.