Skip to content

Conversation

@AlexFenlon
Copy link
Contributor

@AlexFenlon AlexFenlon commented Feb 28, 2025

Proposed changes

  • Add doc changes to configmap keys for Add zone-sync with no TLS to ConfigMap #7347
  • Add notice to let users that previously used snippets to remove it before enabling. the new zone-sync
  • updated a mention of zone-sync in OIDC docs to reflect these changes

Resolves: #7277

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
@AlexFenlon AlexFenlon requested review from a team as code owners February 28, 2025 14:28
@github-actions github-actions bot added the documentation Pull requests/issues for documentation label Feb 28, 2025
@github-actions
Copy link
Contributor

Deploy Preview will be available once build job completes!

Name Link
😎 Deploy Preview https://frontdoor-test-docs.nginx.com/previews/nginx-ingress-controller/7434/

Copy link
Contributor

@javorszky javorszky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these new options have default values? If I don't set a zone-sync-resolver-valid option, what's the TTL going to be?

What's the default for the ipv6?

…urce.md Co-authored-by: Gabor Javorszky <g.javorszky@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
@AlexFenlon
Copy link
Contributor Author

AlexFenlon commented Feb 28, 2025

Do these new options have default values? If I don't set a zone-sync-resolver-valid option, what's the TTL going to be?

What's the default for the ipv6?

@javorszky

Yes, these new options have default values, IF zone-sync is set and only if zone-sync is set.
If you try to enable zone-sync-resolver-valid for example, it will tell you to enable zone-sync first.

the default for IPV6 on/true as it is it also nginx's default here.
Screenshot 2025-02-28 at 14 38 56

the default config is below if the user has zone-sync: "true" and is using a deployment (replicaset)

 server { listen 12345; listen [::]:12345; resolver kube-dns.kube-system.svc.cluster.local valid=5s; zone_sync; zone_sync_server nginx-ingress-replicaset-headless.nginx-ingress-replicaset.svc.cluster.local:12345 resolve; } 
Copy link
Contributor

@jjngx jjngx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

…urce.md Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
AlexFenlon and others added 2 commits February 28, 2025 15:26
…urce.md Co-authored-by: Venktesh Shivam Patel <ve.patel@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
Signed-off-by: AlexFenlon <a.fenlon@f5.com>
Copy link
Member

@ADubhlaoich ADubhlaoich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally LGTM but please look at my edit suggestions.

AlexFenlon and others added 2 commits February 28, 2025 15:48
Co-authored-by: Alan Dooley <a.dooley@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
@AlexFenlon AlexFenlon merged commit 9a0a3f7 into main Feb 28, 2025
30 checks passed
@AlexFenlon AlexFenlon deleted the docs/zone-sync branch February 28, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Pull requests/issues for documentation

6 participants