Skip to content

Conversation

@pdabelf5
Copy link
Collaborator

@pdabelf5 pdabelf5 commented Jan 28, 2025

Proposed changes

Small refactor to put all related policy configuration into one structure:

  • RateLimit
  • JWTAuth
  • APIKey

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
@pdabelf5 pdabelf5 requested a review from a team as a code owner January 28, 2025 14:59
@github-actions github-actions bot added the go Pull requests that update Go code label Jan 28, 2025
@codecov
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 76.81159% with 16 lines in your changes missing coverage. Please review.

Project coverage is 52.70%. Comparing base (bce0a1c) to head (7914235).
Report is 142 commits behind head on main.

Files with missing lines Patch % Lines
internal/configs/virtualserver.go 76.81% 13 Missing and 3 partials ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## main #7232 +/- ## ========================================== - Coverage 52.72% 52.70% -0.02%  ========================================== Files 89 89 Lines 20843 20843 ========================================== - Hits 10989 10985 -4  - Misses 9396 9398 +2  - Partials 458 460 +2 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@pdabelf5 pdabelf5 changed the title refactor rate limit policy config struct refactor policy config structs Jan 28, 2025
@pdabelf5 pdabelf5 marked this pull request as draft January 28, 2025 16:37
@pdabelf5 pdabelf5 marked this pull request as ready for review January 28, 2025 17:05
@pdabelf5 pdabelf5 requested a review from jjngx January 28, 2025 17:05
@pdabelf5 pdabelf5 merged commit 4dbfc2e into main Jan 29, 2025
74 checks passed
@pdabelf5 pdabelf5 deleted the rate-limit-policy-config-refactor branch January 29, 2025 10:51
pdabelf5 added a commit that referenced this pull request Jan 30, 2025
@pdabelf5 pdabelf5 added chore Pull requests for routine tasks and removed go Pull requests that update Go code labels Apr 4, 2025
@pdabelf5 pdabelf5 changed the title refactor policy config structs Refactor policy config structs Apr 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Pull requests for routine tasks

4 participants