Skip to content

Conversation

@nginx-bot
Copy link
Contributor

Proposed changes

  • Adding mgmt configmap tests
  • Fix bug: at runtime a mgmt ClientAuth cert was in the wrong directory.

Checklist

Before creating a PR, run through this checklist and mark each as complete.

  • I have read the CONTRIBUTING doc
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked that all unit tests pass after adding my changes
  • I have updated necessary documentation
  • I have rebased my branch onto main
  • I will ensure my PR is targeting the main branch and pulling from my branch from my own fork
* test full mgmt config params * fix mgmt client auth runtime secret location * add test for full suit of mgmt configmap params * update snaps, fix signature in tests * update snaps
@nginx-bot nginx-bot requested a review from a team as a code owner December 12, 2024 09:13
@nginx-bot nginx-bot added go Pull requests that update Go code needs cherry pick Cherry pick this PR into a release branch python Pull requests that update Python code tests Pull requests that update tests labels Dec 12, 2024
@codecov
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 28.57143% with 25 lines in your changes missing coverage. Please review.

Project coverage is 52.54%. Comparing base (025ddd7) to head (60d540b).

Files with missing lines Patch % Lines
internal/k8s/controller.go 0.00% 21 Missing ⚠️
internal/configs/configurator.go 71.42% 4 Missing ⚠️
Additional details and impacted files
@@ Coverage Diff @@ ## release-4.0 #6965 +/- ## =============================================== - Coverage 52.59% 52.54% -0.05%  =============================================== Files 88 88 Lines 20789 20803 +14 =============================================== - Hits 10933 10931 -2  - Misses 9401 9417 +16  Partials 455 455 

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@j1m-ryan j1m-ryan merged commit 0b7558e into release-4.0 Dec 12, 2024
21 checks passed
@j1m-ryan j1m-ryan deleted the cherry-pick-release-4.0-e12755800ca113e059765f33ef5f14d5a11d6116 branch December 12, 2024 09:43
@pdabelf5 pdabelf5 removed go Pull requests that update Go code python Pull requests that update Python code needs cherry pick Cherry pick this PR into a release branch labels Dec 13, 2024
@pdabelf5 pdabelf5 changed the title [cherry-pick] Add mgmt configmap tests Add mgmt configmap tests Dec 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

tests Pull requests that update tests

6 participants