Remove deprecated log level parameters #6620
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
github-actions bot added go 
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@ ## main #6620 +/- ## ========================================== + Coverage 53.24% 53.26% +0.01% ========================================== Files 87 87 Lines 16263 16257 -6 ========================================== Hits 8660 8660 + Misses 7188 7182 -6 Partials 415 415 ☔ View full report in Codecov by Sentry. |
jjngx reviewed Oct 9, 2024
Contributor
✅ Deploy Preview will be available once build job completes!
|
ADubhlaoich approved these changes Oct 9, 2024
Member
ADubhlaoich left a comment
ADubhlaoich left a comment There was a problem hiding this comment.
LGTM, though the PR is largely not docs-based.
| can you update the docs here https://github.com/nginxinc/kubernetes-ingress/blob/main/site/content/logging-and-monitoring/logging.md? |
j1m-ryan reviewed Oct 9, 2024
Co-authored-by: Jim Ryan <j.ryan@f5.com> Signed-off-by: AlexFenlon <a.fenlon@f5.com>
j1m-ryan approved these changes Oct 9, 2024
pdabelf5 changed the title -v= to -log-level= Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Proposed changes
healthcheckpackage soon by removing a check forlogtostderrandinclude_yearflags aslogtostderrwas included with glog andinclude_yearhas been removed.-v=to-log-level=as it was only used for glog which has now been switched out and-v=has no longer been used since Add LogLevel & LogFormat flags #6520What logtostderr flag was doing in glog
Helm-chart will need to be updated to v2.0.0 as we have a breaking change changing from
-vto-log-levelso this needs to be doneChecklist
Before creating a PR, run through this checklist and mark each as complete.