Skip to content

Conversation

VitaliyR
Copy link
Contributor

🎉 Thanks for submitting a pull request! 🎉

Summary

If preview server does the proxy e.g. to internal routes or the user site proxy-all * - we not notifying activity.


For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures your code follows our style guide and
    passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@VitaliyR VitaliyR requested a review from a team as a code owner June 22, 2025 14:30
@VitaliyR VitaliyR requested review from aitchiss and denar90 June 22, 2025 14:30
Copy link

github-actions bot commented Jun 22, 2025

📊 Benchmark results

Comparing with f449ad8

  • Dependency count: 1,102 (no change)
  • Package size: 276 MB ⬇️ 0.00% decrease vs. f449ad8
  • Number of ts-expect-error directives: 399 (no change)
@VitaliyR VitaliyR force-pushed the vitaliir/notify-activity-fix branch from c39e623 to 2b9c720 Compare June 23, 2025 13:07

const maybeNotifyActivity = () => {
if (req.method === 'GET' && api && process.env.NETLIFY_DEV_SERVER_ID) {
if (api && process.env.NETLIFY_DEV_SERVER_ID && (req.method === 'GET' || req.url?.includes('/.ntlfy-dev/'))) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is /.ntlfy-dev/ at the beginning of the URL path? If so, so we check for that specifically as opposed to allowing it anywhere on the URL?

@VitaliyR VitaliyR force-pushed the vitaliir/notify-activity-fix branch from 2b9c720 to 51f520f Compare June 23, 2025 15:18
@VitaliyR VitaliyR merged commit e6f0d1b into main Jun 23, 2025
47 checks passed
@VitaliyR VitaliyR deleted the vitaliir/notify-activity-fix branch June 23, 2025 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants