fix: pass config object to devCommand step handler #6095
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
🎉 Thanks for submitting a pull request! 🎉
Summary
Fixes WRFL-2278
When plugins overrides the ENV via writing into
args[0].netlifyConfig.build.environment, this new value is being applied to the environment.But later on, the
netlify cli, when it starts the dev server, it never passes this changed env var into itHere is the dev Command
https://github.com/netlify/cli/blob/main/src/utils/run-build.ts#L90
startFrameworkServerpassessettings, which hasenvbut it's typically empty.So, if I'm having a plugin which does change the env, it is never got into the user app.
To fix this, I'm just providing the arguments into the
devCommandcall, so then the place-of-usage (in this case - netlify-cli) can use it like that:Appropriate PR in CLI which supposed to use this PR - netlify/cli#7045
For us to review and ship your PR efficiently, please perform the following steps:
we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
something that`s on fire 🔥 (e.g. incident related), you can skip this step.
your code follows our style guide and passes our tests.
A picture of a cute animal (not mandatory, but encouraged)