Skip to content

Conversation

@mrstork
Copy link
Contributor

@mrstork mrstork commented Dec 6, 2024

Summary

  • The new noble image uses the latest deno version
  • The removed comment is out of date, because the linked ticket mentions a fix was made in 1.46.0
  • We are bumping the low end of the version because we rely on a fix for AbortSignal made in 1.39.0

TODO:

  • Before merging update required test list

For us to review and ship your PR efficiently, please perform the following steps:

  • Open a bug/issue before writing your code 🧑‍💻. This ensures
    we can discuss the changes and get feedback from everyone that should be involved. If you`re fixing a typo or
    something that`s on fire 🔥 (e.g. incident related), you can skip this step.
  • Read the contribution guidelines 📖. This ensures
    your code follows our style guide and passes our tests.
  • Update or add tests (if any source code was changed or added) 🧪
  • Update or add documentation (if features were changed or added) 📝
  • Make sure the status checks below are successful ✅

A picture of a cute animal (not mandatory, but encouraged)

@mrstork mrstork requested a review from a team as a code owner December 6, 2024 18:27
@mrstork mrstork changed the title Update DENO_VERSION_RANGE fix: update DENO_VERSION_RANGE Dec 10, 2024
eduardoboucas
eduardoboucas previously approved these changes Dec 11, 2024
@mrstork mrstork enabled auto-merge (squash) December 11, 2024 17:24
@mrstork mrstork merged commit 5bb784a into main Dec 11, 2024
38 checks passed
@mrstork mrstork deleted the update-deno-version-range branch December 11, 2024 17:50
This was referenced Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants