Skip to content
This repository was archived by the owner on Oct 19, 2022. It is now read-only.

Commit 6819f45

Browse files
author
Maciej Myśliński
committed
Bump react-hot-loader version to 4
1 parent c240cbb commit 6819f45

File tree

4 files changed

+5
-22
lines changed

4 files changed

+5
-22
lines changed

packages/react-scripts/config/webpack.config.dev.js

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,8 +41,6 @@ module.exports = {
4141
// This means they will be the "root" imports that are included in JS bundle.
4242
// The first two entry points enable "hot" CSS and auto-refreshes for JS.
4343
entry: [
44-
// React Hot Loader v3
45-
require.resolve('react-hot-loader/patch'),
4644
// Include an alternative client for WebpackDevServer. A client's job is to
4745
// connect to WebpackDevServer by a socket and get notified about changes.
4846
// When you save a file, the client will either apply hot updates (in case

packages/react-scripts/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,7 @@
7777
"devDependencies": {
7878
"react": "^16.0.0",
7979
"react-dom": "^16.0.0",
80-
"react-hot-loader": "^3.1.3",
80+
"react-hot-loader": "^4.3.2",
8181
"normalize.css": "^7.0.0"
8282
},
8383
"optionalDependencies": {

packages/react-scripts/scripts/init.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -101,7 +101,7 @@ module.exports = function(
101101
command = 'npm';
102102
args = ['install', '--save', verbose && '--verbose'].filter(e => e);
103103
}
104-
args.push('react', 'react-dom', 'react-hot-loader@^3.1.3', 'normalize.css');
104+
args.push('react', 'react-dom', 'react-hot-loader@^4.3.2', 'normalize.css');
105105

106106
// Install additional template dependencies, if present
107107
const templateDependenciesPath = path.join(
Lines changed: 3 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,13 @@
11
import React from 'react';
22
import ReactDOM from 'react-dom';
3-
import { AppContainer } from 'react-hot-loader';
3+
import { hot } from 'react-hot-loader';
44
import 'normalize.css';
55

66
import App from 'components/App';
77
import registerServiceWorker from 'utils/registerServiceWorker';
88

9-
function render(Component) {
10-
ReactDOM.render(
11-
<AppContainer>
12-
<Component />
13-
</AppContainer>,
14-
document.getElementById('root'),
15-
);
16-
}
9+
const HotApp = hot(module)(App);
1710

18-
render(App);
19-
20-
if (module.hot) {
21-
module.hot.accept('./components/App', () => {
22-
// eslint-disable-next-line global-require
23-
const nextApp = require('./components/App').default;
24-
render(nextApp);
25-
});
26-
}
11+
ReactDOM.render(<HotApp />, document.getElementById('root'));
2712

2813
registerServiceWorker();

0 commit comments

Comments
 (0)