Skip to content

Conversation

d-koppenhagen
Copy link
Contributor

@d-koppenhagen d-koppenhagen commented Jun 18, 2020

…based setup

fixes: #278

PR Checklist

What is the current behavior?

Currently @angular/http is added as a dependency but it doesn't longer exist

What is the new behavior?

The dependency is not added anymore

closes #278

@cla-bot cla-bot bot added the cla: yes label Jun 18, 2020
@acoppola
Copy link

wait, still don't work for me, need to change the version of: "@nativescript/schematics": "~2.0.0" to 9.0.0 to make it work.

@d-koppenhagen
Copy link
Contributor Author

Yes there is still the fix for #279 missing

@d-koppenhagen
Copy link
Contributor Author

@NathanWalker could you have a look at it and verify it?

@NathanWalker NathanWalker merged commit b5678dd into NativeScript:master Jun 27, 2020
@d-koppenhagen
Copy link
Contributor Author

@NathanWalker I just checked the schematics locally and it seems that this commit: b7f3131 doesn't work as expected. In other projects I have been worked on the part:

 "ng-add": { "save": "devDependencies" }, "ng-new": { "save": "devDependencies" }, 

was causing the current schematic version is added after the schematics ran.
But fo some reason it doesn't work.

Or is it maybe just a local problem I have on my machine?
Can you check this?

@NathanWalker
Copy link
Contributor

Yep I’ll be checking on Monday ng-add before publishing any update - thanks for this 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3 participants