clippy

Author: Brooooooklyn

benches/escape.rs

@@ -2,9 +2,11 @@ use std::{fs, hint::black_box};
 
 use criterion::{Criterion, criterion_group, criterion_main};
 
+#[cfg(not(feature = "codspeed"))]
 use generic::escape_generic;
 use json_escape_simd::escape;
 
+#[cfg(not(feature = "codspeed"))]
 mod generic;
 
 fn get_rxjs_sources() -> Vec<String> {

src/lib.rs

@@ -563,9 +563,9 @@ mod tests {
  .iter()
  .take(if cfg!(miri) { 10 } else { sources.len() })
  {
- assert_eq!(escape(&source), serde_json::to_string(&source).unwrap());
+ assert_eq!(escape(source), serde_json::to_string(&source).unwrap());
  let mut output = String::new();
- escape_into(&source, unsafe { output.as_mut_vec() });
+ escape_into(source, unsafe { output.as_mut_vec() });
  assert_eq!(output, serde_json::to_string(&source).unwrap());
  }
  }
@@ -603,10 +603,8 @@ mod tests {
  for entry in dir {
  let p = entry?;
  let metadata = std::fs::metadata(p.path())?;
- if metadata.is_file() {
- if f(p.path()) {
- sources.push(std::fs::read_to_string(p.path())?);
- }
+ if metadata.is_file() && f(p.path()) {
+ sources.push(std::fs::read_to_string(p.path())?);
  }
  if metadata.is_dir() {
  read_dir_recursive(p.path(), sources, f)?;

src/simd/v128.rs

@@ -42,8 +42,8 @@ impl Simd for Simd128u {
 
  fn le(&self, rhs: &Self) -> Self::Mask {
  let mut mask = [0u8; 16];
- for i in 0..Self::LANES {
- mask[i] = if self.0[i] <= rhs.0[i] { 1 } else { 0 };
+ for (i, item) in mask.iter_mut().enumerate().take(Self::LANES) {
+ *item = if self.0[i] <= rhs.0[i] { 1 } else { 0 };
  }
  Mask128(mask)
  }
@@ -76,8 +76,8 @@ impl BitAnd for Mask128 {
 
  fn bitand(self, rhs: Self) -> Self::Output {
  let mut result = [0u8; 16];
- for i in 0..16 {
- result[i] = self.0[i] & rhs.0[i];
+ for (i, item) in result.iter_mut().enumerate() {
+ *item = self.0[i] & rhs.0[i];
  }
  Mask128(result)
  }
@@ -88,8 +88,8 @@ impl BitOr for Mask128 {
 
  fn bitor(self, rhs: Self) -> Self::Output {
  let mut result = [0u8; 16];
- for i in 0..16 {
- result[i] = self.0[i] | rhs.0[i];
+ for (i, item) in result.iter_mut().enumerate() {
+ *item = self.0[i] | rhs.0[i];
  }
  Mask128(result)
  }