Skip to content

Conversation

@wuwen5
Copy link
Contributor

@wuwen5 wuwen5 commented Jan 2, 2024

Reopen from #838 and related #2921

@coveralls
Copy link

coveralls commented Jan 2, 2024

Coverage Status

coverage: 87.144% (+0.03%) from 87.116%
when pulling 0379d03 on wuwen5:refactor-cache-decorate
into 4c9d63d on mybatis:master.

@harawata
Copy link
Member

I expressed my concern about allowing direct access to the wrapped instances.
My personal opinion is: if you want to see the cache statistics, you should use some third party cache implementation instead of MyBatis' internal cache.

@wuwen5 wuwen5 force-pushed the refactor-cache-decorate branch from a795b01 to bc5c175 Compare February 18, 2024 01:35
@wuwen5 wuwen5 force-pushed the refactor-cache-decorate branch from bc5c175 to 0379d03 Compare February 18, 2024 02:32
@wuwen5
Copy link
Contributor Author

wuwen5 commented Feb 18, 2024

  • The access level of the getDelegate() has been modified to protected.
  • Removed the getHits() from LoggingCache
@harawata
Copy link
Member

@wuwen5 ,

I'm sorry for the belated response.
I have taken a look at this several times actually, but I still prefer keeping these cache implementations loosely coupled.

@hazendaz ,
If you like this, feel free to merge.
I won't object.

@hazendaz
Copy link
Member

hazendaz commented Apr 4, 2024

Will circle back on this in some time. I think the general idea was that users wanted it and I believe I suggested it was ok to create new PR bringing others up to date. I do not have any strong preference either way.

@wuwen5
Copy link
Contributor Author

wuwen5 commented Feb 20, 2025

keep loosely coupled.

@wuwen5 wuwen5 closed this Feb 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

4 participants