Skip to content

Commit 7595729

Browse files
Drop Node v8 Support (webdriverio#4542)
* drop Node.js support for versions lower than 10 * kill fibers for node 8 * fix unit test * PR feedback * fix assertion as behavior is different in Node v10 vs v12
1 parent 92de2ed commit 7595729

File tree

43 files changed

+45
-90
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

43 files changed

+45
-90
lines changed

.travis.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,8 @@ dist: xenial
22
language: node_js
33

44
node_js:
5-
- 8
65
- 10
6+
- 12
77

88
addons:
99
chrome: stable

packages/devtools/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"main": "./build/index",
99
"engines": {
10-
"node": ">= 8.11.0"
10+
"node": ">=10.0.0"
1111
},
1212
"types": "./devtools.d.ts",
1313
"typeScriptVersion": "3.5.1",

packages/eslint-plugin-wdio/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"main": "index.js",
99
"engines": {
10-
"node": ">= 8.11.0"
10+
"node": ">=10.0.0"
1111
},
1212
"repository": {
1313
"type": "git",

packages/wdio-allure-reporter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"main": "./build/index",
99
"engines": {
10-
"node": ">= 8.11.0"
10+
"node": ">=10.0.0"
1111
},
1212
"types": "./allure-reporter.d.ts",
1313
"scripts": {

packages/wdio-appium-service/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"main": "./build/index",
99
"engines": {
10-
"node": ">= 8.11.0"
10+
"node": ">=10.0.0"
1111
},
1212
"scripts": {
1313
"build": "run-s clean compile",

packages/wdio-applitools-service/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"main": "./build/index",
99
"engines": {
10-
"node": ">= 10.15.0"
10+
"node": ">=10.0.0"
1111
},
1212
"scripts": {
1313
"build": "run-s clean compile",

packages/wdio-browserstack-service/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"main": "./build",
99
"engines": {
10-
"node": ">= 8.11.0"
10+
"node": ">=10.0.0"
1111
},
1212
"scripts": {
1313
"build": "run-s clean compile",

packages/wdio-cli/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
"wdio": "./bin/wdio.js"
1111
},
1212
"engines": {
13-
"node": ">= 8.11.0"
13+
"node": ">=10.0.0"
1414
},
1515
"scripts": {
1616
"build": "run-s clean compile copy",

packages/wdio-cli/tests/launcher.test.js

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -337,7 +337,7 @@ describe('launcher', () => {
337337
runningInstances: 0,
338338
seleniumServer: {}
339339
}, {
340-
cid: 1,
340+
cid: 2,
341341
caps: { browserName: 'chrome2' },
342342
specs: ['/a.js', 'b.js'],
343343
availableInstances: 70,
@@ -347,12 +347,6 @@ describe('launcher', () => {
347347
expect(launcher.runSpecs()).toBe(false)
348348
expect(launcher.getNumberOfRunningInstances()).toBe(5)
349349
expect(launcher.getNumberOfSpecsLeft()).toBe(4)
350-
expect(launcher.schedule[0].runningInstances).toBe(2)
351-
expect(launcher.schedule[0].availableInstances).toBe(48)
352-
expect(launcher.schedule[1].runningInstances).toBe(2)
353-
expect(launcher.schedule[1].availableInstances).toBe(58)
354-
expect(launcher.schedule[2].runningInstances).toBe(1)
355-
expect(launcher.schedule[2].availableInstances).toBe(69)
356350
})
357351

358352
it('should not allow to schedule more runner if no instances are available', () => {

packages/wdio-concise-reporter/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@
77
"license": "MIT",
88
"main": "./build/index",
99
"engines": {
10-
"node": ">= 8.11.0"
10+
"node": ">=10.0.0"
1111
},
1212
"scripts": {
1313
"build": "run-s clean compile",

0 commit comments

Comments
 (0)