Fix parser to reject (|) as syntax error per ISO spec #3141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fixes mthom#3140 The parser was incorrectly accepting (|) and converting it to the atom '|', when it should produce a syntax_error according to ISO/IEC 13211-1 Technical Corrigendum 2, Section C2. Changes: - Modified reduce_brackets() in parser.rs to reject HeadTailSeparator inside parentheses, treating (|) as incomplete/forbidden syntax - Updated builtins.pl to use quoted atom '|' instead of (|) in error term - Added comprehensive tests in src/tests/iso_syntax_errors.pl covering: * (|) syntax error * ISO operator creation restrictions for {} and '|' * Valid operator declarations with proper priorities
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #3140
The parser was incorrectly accepting
(|)and converting it to the atom'|', when it should produce asyntax_erroraccording to ISO/IEC 13211-1 Technical Corrigendum 2, Section C2.Changes
reduce_brackets()inparser.rsto rejectHeadTailSeparatorinside parentheses, treating(|)as incomplete/forbidden syntaxbuiltins.plto use quoted atom'|'instead of(|)in error termsrc/tests/iso_syntax_errors.plcovering:(|)syntax error{}and'|'Test Results
All tests pass including the new ISO syntax error tests.
Reference