Adding verilator support #32
Merged
+141 −4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Contributor
| Thank you for your good work. |
Contributor Author
| sure. I can do that. |
updated the package.json for verilator removed notices about errors in submodules.
Contributor Author
| updates added. |
Contributor Author
| fixed a typo in the readme. |
Owner
| Ok. |
Contributor
| The packages vsce, yo and code-generator are added as dependencies in package.json. Yet they are not used anywhere. What was your intent of adding them? |
Contributor Author
| Apologies. I had thought i'd removed them in the diff. They get added automatically when building for me. |
mshr-h pushed a commit that referenced this pull request Sep 23, 2018
* First step in integrating System Verilog Migrated syntax highlighting and snippets * Ported "Hover variable declaration" It now supports both verilog and systemverilog * tags parser working. Issues with range * Adding verilator support (#32) * Adding verilator support * updated the readme for verilator updated the package.json for verilator removed notices about errors in submodules. * Update README.md * Crude, yet working ctags symbol provider * separated ctags logic from others * basic implementation of Hover provider * Basic Definition Provider done * Code clean up and comments
Contributor Author
| Would you like me to raise another pull request to remove the dependencies? … On 20 Sep 2018, at 19:41, Raamakrishnan A. ***@***.***> wrote: The packages vsce, yo and code-generator are added as dependencies in package.json. Yet they are not used anywhere. What was your intent of adding them? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread. |
Contributor
| I am not sure. I will let @mshr-h to decide |
Owner
| Ok. |
mshr-h added a commit that referenced this pull request Nov 16, 2018
* First step in integrating System Verilog (#26) Migrated syntax highlighting and snippets * Ctags Integration (#33) * First step in integrating System Verilog Migrated syntax highlighting and snippets * Ported "Hover variable declaration" It now supports both verilog and systemverilog * tags parser working. Issues with range * Adding verilator support (#32) * Adding verilator support * updated the readme for verilator updated the package.json for verilator removed notices about errors in submodules. * Update README.md * Crude, yet working ctags symbol provider * separated ctags logic from others * basic implementation of Hover provider * Basic Definition Provider done * Code clean up and comments * basic completion item provider (#37) * Added module instantiation (#41) * Fixing issue #42 (#43) supporting sv in linters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
i've added ventilator support. Enjoy.