Skip to content

Conversation

catamorphism
Copy link
Contributor

r? @graydon - This pull request continues to sketch out the test cases, this time hopefully with the right directory structure; and adds a sketch of a manual for rustpkg.

@steveklabnik
Copy link
Contributor

I only read the docs but I like them. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd use "workspace" rather than "package source" here; too confusable with the src/ subdir and/or the place you downloaded the package from.

@brson
Copy link
Contributor

brson commented Apr 19, 2013

This is looking good. Thanks.

@asb
Copy link

asb commented Apr 20, 2013

@catamorphism It strikes me that rustpkg.md discusses conventions for bench, test, lib and bin but says nothing about documentation. I know API docs are likely to be extracted using rustdoc, but many projects may (I'm an optimist!) include tutorial-style introductions and the like, or at least a README and LICENSE/COPYING file. Presumably it would make sense to install these.

I agree with @graydon that 'workspace' makes more sense than 'package source' (which to me suggests the upstream git repo, which you'd expect wouldn't contain a 'build' dir).

@brson
Copy link
Contributor

brson commented Apr 20, 2013

+1 to teaching rustpkg about docs

@catamorphism
Copy link
Contributor Author

I will incorporate these comments and then push a new commit to this branch.

@catamorphism
Copy link
Contributor Author

@asb : Good suggestion, but beyond the scope of this pull request. I filed a separate issue, #6005.

@catamorphism
Copy link
Contributor Author

So as to preserve comments, I'll actually just open a new pull request.

flip1995 pushed a commit to flip1995/rust that referenced this pull request Aug 28, 2020
Fix ICE in `repeat_once` changelog: Fix ICE in [`repeat_once`] Fixes rust-lang#5944
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants