ui: Select by class instead of (multiple) id #1370
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
mrstegeman reviewed Sep 24, 2018
Contributor
mrstegeman left a comment
mrstegeman left a comment There was a problem hiding this comment.
Don't you need to add ${BaseComponent.count} to the templates as well?
Codecov Report
@@ Coverage Diff @@ ## master #1370 +/- ## ========================================== + Coverage 74.69% 74.79% +0.09% ========================================== Files 127 127 Lines 6118 6118 Branches 854 854 ========================================== + Hits 4570 4576 +6 + Misses 1368 1363 -5 + Partials 180 179 -1
Continue to review full report at Codecov.
|
Contributor Author
| Not really this was only needed for CSS rule for switch (for id). I could use the counter for the slider test, but I guess it thought just add confusion ( count ~= 6 ) and just use the hardcoded one ("slider"). But I can also share an other next change that introduce the counter just for unification of style of templates. |
Contributor
| @rzr It would make sense to me to be consistent. Can you push that change up to this PR? |
In case of multiple property of same types, UI events were forwarded to 1st instance of widget. This change is a follow up of the switch change: Origin: WebThingsIO#1370 Bug: WebThingsIO#1148 Relate-to: WebThingsIO#1249 Change-Id: I2018092168af14eb8f6f1e9e230e04a432490045 Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr force-pushed the sandbox/rzr/review/fix/master branch from 5a9ceda to 4121248 Compare rzr pushed a commit to TizenTeam/gateway that referenced this pull request Sep 24, 2018
This change has no real effect, only for making code more uniform, Note that slider id has been renamed to slider-level to remove ambiguity with slider, and counter suffix adjusted. Forwarded: WebThingsIO#1370 Change-Id: I64fe6a78a8ae9d300bab58561a7b0eec7bfb09db Signed-off-by: Philippe Coval <philippe.coval.pro@gmail.com>
rzr force-pushed the sandbox/rzr/review/fix/master branch from 4121248 to df24dae Compare rzr added a commit to TizenTeam/gateway that referenced this pull request Sep 24, 2018
This change has no real effect, only for making code more uniform, Note that slider id has been renamed to slider-level to remove ambiguity with slider, and counter suffix adjusted. Forwarded: WebThingsIO#1370 Change-Id: I64fe6a78a8ae9d300bab58561a7b0eec7bfb09db Signed-off-by: Philippe Coval <p.coval@samsung.com>
mrstegeman suggested changes Sep 24, 2018
| | ||
| async getValue() { | ||
| const slider = await this.slider(); | ||
| console.log(slider); |
This change has no real effect, only for making code more uniform, Note that slider id has been renamed to slider-level to remove ambiguity with slider, and counter suffix adjusted. Forwarded: WebThingsIO#1370 Change-Id: I64fe6a78a8ae9d300bab58561a7b0eec7bfb09db Signed-off-by: Philippe Coval <p.coval@samsung.com>
rzr force-pushed the sandbox/rzr/review/fix/master branch from df24dae to 0c3ea5f Compare mrstegeman approved these changes Sep 25, 2018
ghost removed the Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
In case of multiple property of same types,
UI events were forwarded to 1st instance of widget.
This change is a follow up of the switch change:
Bug: #1148
Relate-to: #1249
Change-Id: I2018092168af14eb8f6f1e9e230e04a432490045
Signed-off-by: Philippe Coval p.coval@samsung.com